Problem/Motivation
phpcs reports,
FILE: src/Service/LoginService.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
153 | ERROR | [ ] Comment indentation error, expected only 1 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
154 | WARNING | [x] There must be no blank line following an inline comment
| | (Drupal.Commenting.InlineComment.SpacingAfter)
154 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: src/Repository/TokenRepository.php
---------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
---------------------------------------------------------------------------------------------------------------------
123 | ERROR | Missing parameter comment (Drupal.Commenting.FunctionComment.MissingParamComment)
125 | ERROR | Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)
134 | ERROR | Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
135 | ERROR | Missing parameter comment (Drupal.Commenting.FunctionComment.MissingParamComment)
137 | ERROR | Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)
150 | ERROR | Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
151 | ERROR | Missing parameter comment (Drupal.Commenting.FunctionComment.MissingParamComment)
153 | ERROR | Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)
---------------------------------------------------------------------------------------------------------------------
FILE: src/Model/Token.php
------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------------------
9 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
35 | ERROR | [ ] Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
40 | ERROR | [ ] Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
45 | ERROR | [ ] Parameter $createdAt is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
45 | ERROR | [ ] Parameter $refreshedAt is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
55 | ERROR | [x] Parameter $createdAt has null default value, but is not marked as nullable.
| | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
55 | ERROR | [x] Parameter $refreshedAt has null default value, but is not marked as nullable.
| | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
93 | ERROR | [ ] Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
94 | ERROR | [ ] Description for the @return value is missing
| | (Drupal.Commenting.FunctionComment.MissingReturnComment)
100 | ERROR | [ ] Missing short description in doc comment (Drupal.Commenting.DocComment.MissingShort)
101 | ERROR | [ ] Description for the @return value is missing
| | (Drupal.Commenting.FunctionComment.MissingReturnComment)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: src/Form/ConfigForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/TokenNotFoundException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/TokenGeneratorException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/InvalidRequestIdException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/EntityNotFoundException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/AuthenticationException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Exception/AccessDeniedException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/EventSubscriber/CacheEndpointSubscriber.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
20 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
42 | ERROR | Doc comment short description must end with a full stop (Drupal.Commenting.DocComment.ShortFullStop)
42 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
| | (Drupal.Commenting.DocComment.ShortSingleLine)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Controller/AuthController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
23 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------------------
FILE: src/Authentication/Provider/AccessTokenProvider.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
19 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
| | (Drupal.Commenting.ClassComment.Short)
132 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 10
| | (Drupal.WhiteSpace.ObjectOperatorIndent.Indent)
135 | ERROR | [x] Expected newline after closing brace
| | (Drupal.ControlStructures.ControlSignature.NewlineAfterCloseBrace)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: rest_api_access_token.install
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
83 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
| | (Drupal.Commenting.DocComment.ShortSingleLine)
------------------------------------------------------------------------------------------------------------------------
Steps to reproduce
see https://git.drupalcode.org/issue/rest_api_access_token-3527128/-/jobs/53...
Remaining tasks
make a MR
Issue fork rest_api_access_token-3546835
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
benstallings commentedComment #4
benstallings commented