Needs review
Project:
Responsive Images
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2012 at 15:44 UTC
Updated:
15 Mar 2012 at 22:40 UTC
The patch add a additional CSS class to make it possible to identify responsive images output.
This is absolutely needed to, for example to display multiple responsive images side by side.
| Comment | File | Size | Author |
|---|---|---|---|
| responsive_images.module.patch | 706 bytes | quiptime |
Comments
Comment #1
svendecabooterThanks for the patch! It doesn't seem to add the class on my testsite though. Are you sure it is hook_process rather then hook_preprocess?
Currently i'm not looking into creating a new release of this module, because it would require some architectural changes, and I don't have the time for those currently. So not sure if you should put a lot of time into this...
Comment #2
quiptime commentedPlease take a look at In which cases should hook_process() and hook_process_HOOK() be used?
That is very unfortunate.
But, to integrate a patch and create a new release can not be a (time) problem.
You are you already aware about the importance of your module?
See: The Drupal 8 Mobile Initiative
Comment #3
svendecabooterYes i'm aware of the importance. I've added some alternative modules to the module information page, because i'm not sure if i'll be able to keep this module maintained and working. I don't want the whole responsive images concept being stalled because of me, so if someone wants to help, by all means ;)
Currently it's not looking like i'll have much time...
I have tried your patch and wanted to integrate it. It just didn't work on my testsite. Will need to allocate some more time to debug.
I'll report back.
Cheers
Comment #4
ruplIt is unfortunate, but Sven is right about not putting a heavy time investment into this module at the present moment. The browsers are changing so rapidly that solutions we implement can break within weeks. For a long-term look at where this type of tech is headed, I'd encourage you to read the Responsive Images Community Group over at the W3.
Comment #5
quiptime commentedI see that but different. Please call me for more than one browser (with changes that affect the responsive images topic) where this is true.
I have read the discussion.
Thanks for pointing this out, but what do you want to tell me in which you referred me to this discussion.
Fact is, the Drupal module "Responsive images" exist. And that's why you should do that it works well.
Comment #6
ruplSure thing. In between the time when you posted comment #5, and the time I'm posting comment #6 (less than 24 hours), a brand new approach has emerged and it doesn't even use
<img>. It's a call for a brand new<picture>tag. Here is the link: https://github.com/scottjehl/picturefillAs a matter of sanity, I have chosen to focus on contributing to W3C first, then port a solution to Drupal once the dust begins to settle.