Problem/Motivation

While not a strict requirement by any means, generally speaking modules use module.settings for maintaining configuration settings. Resource Hints currently uses resource_hints.config.

Resource hints

Proposed resolution

While it's not necessarily a problem, for consistency purposes I recommend switching it to resource_hints.settings instead.

This involves renaming config/install/resource_hints.config.yml to config/install/resource_hints.settings.yml and updating all instances of resource_hints.config to resource_hints.settings anywhere it exists in the rest of codebase.

This is technically a breaking issue if someone already has the module installed, but given that we're still in alpha now is the time to get this change in.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

WidgetsBurritos created an issue. See original summary.

WidgetsBurritos’s picture

Issue summary: View changes
Mashir’s picture

Assigned: Unassigned » Mashir

I am working ng in this.

Mashir’s picture

Status: Active » Needs review
FileSize
5.28 KB

Please find the attached patch as per the above requirement.

WidgetsBurritos’s picture

Status: Needs review » Reviewed & tested by the community

+1 RTBC

  • WidgetsBurritos committed 5c56d37 on 8.x-1.x authored by Mashir
    Issue #2945879 by Mashir, WidgetsBurritos: Rename resource_hints.config...
WidgetsBurritos’s picture

Status: Reviewed & tested by the community » Fixed
WidgetsBurritos’s picture

Status: Fixed » Closed (fixed)