Problem/Motivation
While not a strict requirement by any means, generally speaking modules use module.settings
for maintaining configuration settings. Resource Hints currently uses resource_hints.config
.
Proposed resolution
While it's not necessarily a problem, for consistency purposes I recommend switching it to resource_hints.settings
instead.
This involves renaming config/install/resource_hints.config.yml
to config/install/resource_hints.settings.yml
and updating all instances of resource_hints.config
to resource_hints.settings
anywhere it exists in the rest of codebase.
This is technically a breaking issue if someone already has the module installed, but given that we're still in alpha now is the time to get this change in.
Comment | File | Size | Author |
---|---|---|---|
#4 | rename-2945879-4.patch | 5.28 KB | Mashir |
| |||
Screen Shot 2018-02-19 at 10.39.20 AM.png | 273.63 KB | WidgetsBurritos |
Comments
Comment #2
WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commentedComment #3
Mashir CreditAttribution: Mashir commentedI am working ng in this.
Comment #4
Mashir CreditAttribution: Mashir commentedPlease find the attached patch as per the above requirement.
Comment #5
WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented+1 RTBC
Comment #7
WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commentedComment #8
WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented