Discover and fix any D9 compatibility issues.

Issue fork remp-3138506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lbesenyei created an issue. See original summary.

sahana _n’s picture

Assigned: Unassigned » sahana _n

zaurav made their first commit to this issue’s fork.

ysamoylenko’s picture

Status: Active » Needs review
ysamoylenko’s picture

Status: Needs review » Needs work

Hello @zaurav,
Please take a look at my comment in your merge request;
https://git.drupalcode.org/project/remp/-/merge_requests/1/diffs#6b44eaf...
Changing the issue status to Needs work.

gun2dru’s picture

Hi team,

I've completed code analysis issues in scope of D9 compatibility check, and find:

 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------- 
  Line   remp.module                                             
 ------ -------------------------------------------------------- 
  57     Access to an undefined property                         
         Drupal\Core\Entity\EntityInterface::$remp_member_only.  
  95     Access to an undefined property                         
         Drupal\Core\Entity\EntityInterface::$remp_member_only.  
  98     Call to an undefined method                             
         Drupal\Core\Entity\EntityInterface::getOwner().         
  99     Access to an undefined property                         
         Drupal\Core\Entity\EntityInterface::$remp_member_only.  
 ------ -------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   src/Controller/RempContentController.php                             
 ------ --------------------------------------------------------------------- 
  100    Property                                                             
         Drupal\remp\Controller\RempContentController::$entityTypeManager     
         (Drupal\Core\Entity\EntityTypeManager) does not accept               
         Drupal\Core\Entity\EntityTypeManagerInterface.                       
  101    Property Drupal\remp\Controller\RempContentController::$renderer     
         (Drupal\Core\Render\Renderer) does not accept                        
         Drupal\Core\Render\RendererInterface.                                
  102    Property Drupal\remp\Controller\RempContentController::$httpClient   
         (GuzzleHttp\Client) does not accept GuzzleHttp\ClientInterface.      
  103    Property Drupal\remp\Controller\RempContentController::$formBuilder  
         (Drupal\Core\Form\FormBuilder) does not accept                       
         Drupal\Core\Form\FormBuilderInterface.                               
  126    Method                                                               
         Drupal\remp\Controller\RempContentController::contentResponse()      
         invoked with 3 parameters, 1 required.                               
  290    Variable $view_builder in PHPDoc tag @var does not match assigned    
         variable $viewBuilder.                                               
  317    Variable $paid_url might not be defined.                             
 ------ --------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   src/Form/RempLoginForm.php                                       
 ------ ----------------------------------------------------------------- 
  38     Property Drupal\remp\Form\RempLoginForm::$httpClient             
         (GuzzleHttp\Client) does not accept GuzzleHttp\ClientInterface.  
  39     Access to an undefined property                                  
         Drupal\remp\Form\RempLoginForm::$currentUser.                    
  40     Access to an undefined property                                  
         Drupal\remp\Form\RempLoginForm::$languageManager.                
 ------ ----------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------- 
  Line   src/RempService.php                                                   
 ------ ---------------------------------------------------------------------- 
  66     Property Drupal\remp\RempService::$httpClient (GuzzleHttp\Client)     
         does not accept GuzzleHttp\ClientInterface.                           
  67     Property Drupal\remp\RempService::$configFactory                      
         (Drupal\Core\Config\ConfigFactory) does not accept                    
         Drupal\Core\Config\ConfigFactoryInterface.                            
  68     Property Drupal\remp\RempService::$moduleHandler                      
         (Drupal\Core\Extension\ModuleHandler) does not accept                 
         Drupal\Core\Extension\ModuleHandlerInterface.                         
  229    Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0  
         and is removed from drupal:10.0.0. Use                                
         \Drupal::time()->getRequestTime();                                    
 ------ ---------------------------------------------------------------------- 

 [ERROR] Found 18 errors

Steps to reproduce
Verification by drupal-check tool with flag -a
drupal-check -a modules/contrib/remp/

gun2dru’s picture

Hi there,

After checking by scan utility I have the following results

 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors   

The changes are ready to test. Thanks!

gun2dru’s picture

Status: Needs work » Needs review
ysamoylenko’s picture

Status: Needs review » Reviewed & tested by the community

@gun2dru thank you for the patch.

It fixes the compatibility issues and does not produce any issues in DB Log.

Happy to RTBC!

lbesenyei’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.