Show Replication Remotes forms just when the workspace module is enabled [#2778861]

Instead of adding Workspace module as dependence, on Relaxed Remotes page we need to display a message like You have to install Workspace module prior to set new workspaces and don't display the form if the module is not enabled.

It will fix errors like this:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "workspace_pointer" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 125 of /var/www/drupal8dev/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

Comment	File	Size	Author
#28	show_replication-2778861-28.patch	2.05 KB	jeqq
#28	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 1 fail
#23	show_replication-2778861-23.patch	241 bytes	jeqq
#23	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 1 fail
#19	interdiff.txt	378 bytes	jeqq
#19	show_replication-2778861-19.patch	2.28 KB	jeqq
#19	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 4 fail
#15	interdiff.txt	1.16 KB	jeqq
#15	show_replication-2778861-15.patch	2.05 KB	jeqq
#15	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 2 fail
#12	interdiff.txt	189 bytes	jeqq
#12	show_replication-2778861-12.patch	1006 bytes	jeqq
#12	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 5.6 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 7 & MySQL 5.5, D8.3 Patch failed to apply
#7	show_replication-2778861-7.patch	765 bytes	jeqq
#7	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 5.6 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 3 fail
	add-dependence.patch	221 bytes	jeqq
	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 1 pass, 47 fail PHP 5.6 & MySQL 5.5, D8.3 1 pass, 47 fail PHP 7 & MySQL 5.5, D8.3 1 pass, 45 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 August 2016 at 08:46

jeqq created an issue. See original summary.

Comment #2

4 August 2016 at 09:25

Status:

Needs review

» Needs work

The last submitted patch, add-dependence.patch, failed testing.

Comment #3

4 August 2016 at 09:25

The last submitted patch, add-dependence.patch, failed testing.

Comment #4

4 August 2016 at 09:27

The last submitted patch, add-dependence.patch, failed testing.

Comment #5

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 10:11

Title:	Add Workspace module as dependence	» Show Replication Remotes forms just when the workspace module is enabled
Issue summary:	View changes

Comment #6

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 10:11

Assigned:

Unassigned

» jeqq

Comment #7

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 11:59

File	Size
show_replication-2778861-7.patch	765 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 5.6 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 3 fail

Comment #8

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 11:59

Status:

Needs work

» Needs review

Comment #9

4 August 2016 at 12:06

Status:

Needs review

» Needs work

The last submitted patch, 7: show_replication-2778861-7.patch, failed testing.

Comment #10

4 August 2016 at 12:07

The last submitted patch, 7: show_replication-2778861-7.patch, failed testing.

Comment #11

4 August 2016 at 12:07

The last submitted patch, 7: show_replication-2778861-7.patch, failed testing.

Comment #12

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 12:25

Status:

Needs work

» Needs review

File	Size
show_replication-2778861-12.patch	1006 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 5.6 & MySQL 5.5, D8.3 57 pass, 3 fail PHP 7 & MySQL 5.5, D8.3 Patch failed to apply
interdiff.txt	189 bytes

Added test dependence.

Comment #13

4 August 2016 at 12:31

Status:

Needs review

» Needs work

The last submitted patch, 12: show_replication-2778861-12.patch, failed testing.

Comment #14

4 August 2016 at 12:31

The last submitted patch, 12: show_replication-2778861-12.patch, failed testing.

Comment #15

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 12:43

Status:

Needs work

» Needs review

File	Size
show_replication-2778861-15.patch	2.05 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 2 fail
interdiff.txt	1.16 KB

Comment #16

4 August 2016 at 12:47

Status:

Needs review

» Needs work

The last submitted patch, 15: show_replication-2778861-15.patch, failed testing.

Comment #17

4 August 2016 at 12:48

The last submitted patch, 15: show_replication-2778861-15.patch, failed testing.

Comment #18

4 August 2016 at 12:48

The last submitted patch, 15: show_replication-2778861-15.patch, failed testing.

Comment #19

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 13:05

Status:

Needs work

» Needs review

File	Size
show_replication-2778861-19.patch	2.28 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 4 fail
interdiff.txt	378 bytes

Comment #20

4 August 2016 at 13:10

Status:

Needs review

» Needs work

The last submitted patch, 19: show_replication-2778861-19.patch, failed testing.

Comment #21

4 August 2016 at 13:14

The last submitted patch, 19: show_replication-2778861-19.patch, failed testing.

Comment #22

4 August 2016 at 13:15

The last submitted patch, 19: show_replication-2778861-19.patch, failed testing.

Comment #23

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 14:04

Status:

Needs work

» Needs review

File	Size
show_replication-2778861-23.patch	241 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 1 fail

Trying @DamienMcKenna's solution from https://www.mediacurrent.com/blog/how-fix-testbot-bug-when-adding-new-tests

Comment #24

4 August 2016 at 13:27

Status:

Needs review

» Needs work

The last submitted patch, 23: show_replication-2778861-23.patch, failed testing.

Comment #25

4 August 2016 at 13:27

The last submitted patch, 23: show_replication-2778861-23.patch, failed testing.

Comment #26

4 August 2016 at 13:27

The last submitted patch, 23: show_replication-2778861-23.patch, failed testing.

Comment #27

4 August 2016 at 13:30

jeqq committed 195ef17 on 8.x-1.x

Issue #2778861 by jeqq: Add Workspace module as dependence

jeqq committed 40c10d5 on 8.x-1.x

Revert "Issue #2778861 by jeqq: Add Workspace module as dependence"...

jeqq committed 7df40dc on 8.x-1.x

Issue #2778861 by jeqq: Add test dependence.

Comment #28

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 13:44

Status:

Needs work

» Needs review

File	Size
show_replication-2778861-28.patch	2.05 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 58 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 58 pass, 1 fail

Comment #29

4 August 2016 at 13:49

Status:

Needs review

» Needs work

The last submitted patch, 28: show_replication-2778861-28.patch, failed testing.

Comment #30

4 August 2016 at 13:50

The last submitted patch, 28: show_replication-2778861-28.patch, failed testing.

Comment #31

4 August 2016 at 13:50

The last submitted patch, 28: show_replication-2778861-28.patch, failed testing.

Comment #32

4 August 2016 at 13:54

jeqq committed 4581144 on 8.x-1.x

Issue #2778861 by jeqq: Show Replication Remotes forms just when the...

Comment #33

jeqq

Romanian

CreditAttribution: jeqq at FFW for Pfizer, Inc. commented 4 August 2016 at 14:02

Assigned:	jeqq	» Unassigned
Status:	Needs work	» Closed (fixed)

One test is failing because the branch is failing and it is not related to this patch.

Comment #34

6 August 2016 at 16:21

The last submitted patch, 12: show_replication-2778861-12.patch, failed testing.