Hello,

I am trying to configure Entity registration for a website where each user can register only himself and once per event. I want to keep the registration displayed as a form on the node.
By default, once a user is registered, the form is still visible (although clicking register will always yield an 'already registered' error).

In this case, it would be great to have an option to hide the form for registered users, or even better to display an already registered message instead.
Maybe this is implemented and I did not found it. Otherwise, is there any conceivable workaround?

I thank you in advance for your help. Best regards,

Thomas

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

julou’s picture

Also I did not solved the problem completely yet, I progressed noticeably: I am now stuck trying to theme the registration field from a custom module.
Please read more on this at http://drupal.stackexchange.com/questions/85792/how-to-theme-a-field-for...

Thank you in advance for your help.

PS: Do you think integrating this conditionnal display to the default 'form' field formatter would be relevant?

  • show a 'please login in order to register' to anonymous visitors (in case anonymous registration is disabled)
  • show a 'edit registration' link to already registered users
  • show the registration form, as well as an info message (xx seats left / fully booked but wait list is still open), to not yet registered users.
julou’s picture

Status: Active » Fixed

Solved.

It took me some time to realize that I needed both
- a custom field formatter (to display the registration form to registered users as well)
- a custom theming of the registration field (so as to display either the form or relevant info: registration state, fully booked, etc)

flocondetoile’s picture

Hi julou,

I am searching for similar features. Could you explain me more precisely how you solved this ?

Thanks

jzornig’s picture

Category: support » feature
Status: Fixed » Active

It would be good to have this as a feature. I find it really confusing to see the registration form after I've already registered and just get an error if I click "Save Registration" again. It does not even redirect me to my registration in this case.

The form should say Already Registered and show an "Edit Registration" button.

julou’s picture

Good to read I'm not the only one to think it would be a relevant default behavior for this module :)

In the meantime, here is how I implemented the custom field formatter, and the theming. This is adapted from the registration_field_formatter_view() and related functions. As you can read, my module is called 'zss'. The theming is done for a field named field_registration. You could probably (?) make it more generic by theming by field type.

Hope this helps. Best, Thomas

/**
 * Implements hook_field_formatter_info().
 */
function zss_field_formatter_info() {
  return array(
    'zss_registration_form' => array(
      'label' => t('Custom (ZSS)'),
      'field types' => array('registration'),
    ),
  );
}

/**
 * Implements hook_field_formatter_settings_form().
 */
function zss_field_formatter_settings_form($field, $instance, $view_mode, $form, &$form_state) {
  $display = $instance['display'][$view_mode];
  $settings = $display['settings'];

  $element = array();

  return $element;
}

/**
 * Implements hook_field_formatter_settings_summary().
 */
function zss_field_formatter_settings_summary($field, $instance, $view_mode) {
  $display = $instance['display'][$view_mode];
  $settings = $display['settings'];

  $summary = t('Registration label: Parent label.');

  return $summary;
}

/**
 * Implements hook_field_formatter_view().
 */
function zss_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();

  // we know we should only have a single item
  if (isset($items[0]['registration_type']) && !empty($items[0]['registration_type'])) {
    $reg_type = registration_type_load($items[0]['registration_type']);
    $settings = $display['settings'];
    $label = !empty($settings['label']) ? $settings['label'] : $reg_type->label;

    if ($display['type'] == 'zss_registration_form') {
      // Enable registration link if accessible.
      list($entity_id) = entity_extract_ids($entity_type, $entity);
      if (registration_register_page_access($entity_type, $entity)) { // && registration_status($entity_type, $entity_id)
        $registration = entity_get_controller('registration')->create(array(
          'entity_type' => $entity_type,
          'entity_id' => $entity_id,
          'type' => $reg_type->name,
        ));
        $element[0] = drupal_get_form('registration_form', $registration);
      }
    }
  }

  return $element;
}


/**
 * Determine if a person has an active registration for a host entity.
 * returns the registration_id in this case, 0 otherwise
 */
function zss_user_is_registered($entity_type, $entity_id, $uid) {
  $states = registration_get_active_states();

  $query = db_select('registration', 'r')
    ->fields('r', array('registration_id'))
    ->condition('entity_id', $entity_id)
    ->condition('entity_type', $entity_type)
    ->condition('state', $states, 'IN')
    ->condition('user_uid', $uid);

  $results = $query->execute();
  $ids = array(); $c = 0;
  foreach ($results as $result) {
    $ids[$c++] = $result->registration_id;
  }

  return (sizeof($ids) == 1) ? $ids[0] : 0;
}

/**
 * Theme field_registration 
 */
function zss_field__field_registration($variables) {
  global $user;
  $object = $variables['element']['#object'];  
  $output = '';
  
  // Render the label, if it's not hidden.
  if (!$variables['label_hidden']) {
    $output .= '<div class="field-label"' . $variables['title_attributes'] . '>' . $variables['label'] . ':&nbsp;</div>';
  }

  // Render the items.
  $output .= '<div class="field-items"' . $variables['content_attributes'] . '>';
  foreach ($variables['items'] as $delta => $item) {
    // Compute the rendered registration value
    $rendered_registration = '';
    $user_registration = zss_user_is_registered('node', $object->nid, $user->uid);
    $errors = array();
    $status = registration_status('node', $object->nid, TRUE, 1, NULL, $errors);
    $active_waitlist = registration_waitlist_is_active('node', $object->nid, $errors);
// $output .= $status ? 'available ' : 'full ';
// $output .= $active_waitlist ? 'active' : 'inactive';

    if ($user_registration) {
      $registration = entity_load_single('registration', $user_registration);
      $registration_states = registration_get_states_options();
    
      $rendered_registration = t('You already registered for this tour (@state). <a href="@url">Cancel the registration</a>.', array('@state' => $registration_states[$registration->state], '@url' => url('registration/' . $user_registration . '/delete')));
    } elseif ($status) { 
      if (!$active_waitlist)
        $rendered_registration = drupal_render($item);
      else {
        $rendered_registration = t("All slots have been booked already for this tour. You can still register to the waitlist.");
        $rendered_registration .= drupal_render($item);
      }
    } else
      $rendered_registration = t("This tour is fully booked.");
    
    // Render the item
    $classes = 'field-item ' . ($delta % 2 ? 'odd' : 'even');
    $output .= '<div class="' . $classes . '"' . $variables['item_attributes'][$delta] . '>' . $rendered_registration . '</div>';
  }
  $output .= '</div>';

  // Render the top-level DIV.
  $output = '<div class="' . $variables['classes'] . '"' . $variables['attributes'] . '>' . $output . '</div>';

  return $output;
}
jzornig’s picture

julou, Thanks for this. You will have saved me or one of my developers a heap of work. Cheers, JZ

flocondetoile’s picture

Thank you very much. I will try in the coming weeks.

flocondetoile’s picture

Issue summary: View changes

typo

aucovic’s picture

julou, thanks for the formatter. I've tried it, but unforuntatelly it's not working for me. My module implementation is fine, I'm not getting any error but the module simply doesn't hide the form if user has already registered for the event? Any suggestions?

How about you guys jzornig and flocondetoile? Does it work for you?

aucovic’s picture

In addtition to my previous comment #8:
It seems that hook zss_field__field_registration does not have any effect to the rendered field. My registration field is named "field_registration", so I'm consfused why this hook is not applied to that field?

julou’s picture

@ aucovic:
The formatter does not hide anything: to the contrary, it displays the form also for registered users.
You are right, the problem comes from the fact that your field_registration theming is not working; could you try to do it from a file? or check that the naming convention is ok (e.g. my_module_field__field_name)?

aucovic’s picture

julou, no questions about the naming convention. The function name is correct (in my case entity_registration_custom_field__field_registration). I'm using views module and I made sure the custom formatter is selected as well. This is really very odd. But good idea, I will try it from a file.

I basically understand all what you wrote in the field theming hook, and was so excited when I found it.

Will let you know whether is working via file.
Big thanks julou for this code anyway!

aucovic’s picture

julou, just tested it out with a file template. The template is executed without errors but when $output is printed out, all I get is:

<div class="">
<div class="field-label">: </div>
<div class="field-items"></div>
</div>

What am I missing here?

aucovic’s picture

I ended up implemeting and customizing this formatter: https://drupal.org/comment/7888559#comment-7888559

julou I'm not sure how field hook can acctualy work in your sample since there is a hook_field_formatter_view() implementation which is calling drupal_get_form('registration_form', $registration) and embedding form. I suppose that means the field hook will never be executed.

flocondetoile’s picture

Hi

I used snippet posted by @julou and it works very fine (Thank you very much @julou). The registration form is well hidden if a user is already registered (except for user 1).

I implement the Theme field_registration in my theme template file

THENENAME_field__CUSTOM_FIELD__CONTENTTYPE ($variables)

Best

ptmkenny’s picture

ptmkenny’s picture

ptmkenny’s picture

It would be great to have this as a patch to the module. If a user only has permission to register himself/herself and the user has already registered, it doesn't make any sense to show the registration form to that user.

deggertsen’s picture

You can do this using panels. See #2098779: Display registration page differently for those who already registered

I recognize this is only a workaround so it would be nice for those who don't want to use panels and custom php to have a built in solution.

ptmkenny’s picture

Julou's code in #5 works when the registration form is displayed on the node page, but it doesn't work when displaying multiple registration forms using the field display mode of views.

EDIT: To provide more details, when loading the custom form with Views, it appears that only the first entity is loaded for all instances. So, if I have 10 events, each showing a registration form in Views, there will be 10 registration forms, but all of them are only for the first entity loaded, not #1 form for #1 entity, #2 form for #2 entity, etc.

julou’s picture

A quick update for people using / inspired by the snippet in #5. This syntax has several drawbacks, among which the fact that it is not compatible with the waiting_list submodule.
The following code, relying only on a custom formatter, achieves the same in a cleaner way (and keeps compatibility with waiting_list):

<?php
/**
 * Implements hook_field_formatter_info().
 */
function zss_field_formatter_info() {
  return array(
    'zss_registration_form' => array(
      'label' => t('Custom (ZSS)'),
      'field types' => array('registration'),
    ),
  );
}

/**
 * Implements hook_field_formatter_view().
 */
function zss_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();

  // we know we should only have a single item
  if (isset($items[0]['registration_type']) && !empty($items[0]['registration_type'])) {
    $reg_type = registration_type_load($items[0]['registration_type']);
    $settings = $display['settings'];
    $label = !empty($settings['label']) ? $settings['label'] : $reg_type->label;

    if ($display['type'] == 'zss_registration_form') {
      $account = $GLOBALS['user'];        
      list($entity_id) = entity_extract_ids($entity_type, $entity);
      
      // If the user is already registered, display a link to edit the resgitration
      if ($registration_id = _zss_registration_is_registered_id($entity_type, $entity_id, NULL, $account->uid)) {
        $registration = entity_load_single('registration', $registration_id);
        $registration_states = registration_get_states_options();
        $element[0]['link'] = array(
          '#markup' => t('You already registered for this tour (@state). <a href="@url">Cancel the registration</a>.' . "\n", 
            array('@state' => $registration_states[$registration->state], '@url' => url('registration/' . $registration_id . '/delete'))),
          '#prefix' => '<p>',
          '#suffix' => '</p>',
        );
      }
      // If the user can access the registration, show the form only if the event is not full
      if ($registration_access = registration_register_page_access($entity_type, $entity)) { // && registration_status($entity_type, $entity_id)
        if (registration_status($entity_type, $entity_id)) {
          $registration = entity_get_controller('registration')->create(array(
            'entity_type' => $entity_type,
            'entity_id' => $entity_id,
            'type' => $reg_type->name,
          ));
          $element[0]['form'] = drupal_get_form('registration_form', $registration);
        }
        else {
          $element[0]['form'] = array(
            '#markup' => t('Registrations are no longer available for %name.',
              array('%name' => entity_label($entity_type, $entity))),
            '#prefix' => '<p>',
            '#suffix' => '</p>',
          );
        }
      }
      // Check whether the entity has any registration enabled
      $settings = registration_entity_settings($entity_type, $entity_id);
      $registration_enabled = $settings['status'];
      // Otherwise (registration open, no existing registration, no access), display another message (login link)
      if ($registration_enabled && !$registration_id && !$registration_access) {
        $element[0] = array(
          '#markup' => t('Registration is allowed for members only. Please <a href="@url">login</a> to register.', 
            array('@url' => url('user/login'))),
        );
      }
    }
  } 
  return $element;
}

/**
 * Determine if a person has an active registration for a host entity.
 * modified from registration_is_registered(Registration $registration, $anon_mail = NULL, $uid = NULL, $states = array())
 *
 * A person may be Drupal user account, identified by user uid ($uid).
 * Or a non-user, identified by an email address ($anon_mail).
 *
 * One of $anon_mail or $uid is required.
 *
 * @param int $entity_type
 *   Parent entity type
 * @param int $entity_id
 *   Parent entity id
 * @param string $anon_mail
 *   (optional) An email address.
 * @param int $uid
 *   (optional) A user account uid.
 * @param array $states
 *   (optional) An array of states to test against. Defaults to active states.
 *
 * @return int 
 *   Registration entity id
 */
function _zss_registration_is_registered_id($entity_type, $entity_id, $anon_mail = NULL, $uid = NULL, $states = array()) {
  // must provide an UID or anon_mail
  // @todo: better course of action here?
  if (!$anon_mail && !$uid) {
    return FALSE;
  }

  if (empty($states)) {
    $states = registration_get_active_states();
  }

  $query = db_select('registration', 'r')
    ->fields('r', array('registration_id'))
    ->condition('entity_id', $entity_id)
    ->condition('entity_type', $entity_type)
    ->condition('state', $states, 'IN');

  if ($anon_mail) {
    // There's a user with this email, check to make sure they're not registered.
    if ($user = user_load_by_mail($anon_mail)) {
      $query->condition(db_or()->condition('anon_mail', $anon_mail)
        ->condition('user_uid', $user->uid));
    }
    else {
      $query->condition('anon_mail', $anon_mail);
    }
  }
  elseif ($uid) {
    $query->condition('user_uid', $uid);
  }

  $results = $query->execute();
  $ids = $results->fetchField();
  $id = ($ids=='' ? 0 : $ids);
  return $id;
}
?>

Hope it helps!

benmmc’s picture

#20 works, thanks! I have made two changes below:

  • The registration form was still showing, even if the user was already registered for the event, so I hid the form for users already registered for the event
  • I added a destination to the registration edit URL so the user is redirected back to the event page after they edit or delete their registration (not sure if I did it in the most efficient way, but it works)

Just for clarification, when you use this in a custom module, you aren't touching the individual field theming like in #5, so no need to change a field name to match yours. Also, once it's enabled, go to /admin/structure/types/manage/[your_content_type]/display and change the format of the registration field to "Custom" and it should work.

/**
* Implements hook_field_formatter_info().
*/
function custom_field_formatter_info() {
  return array(
    'custom_registration_form' => array(
      'label' => t('Custom'),
      'field types' => array('registration'),
    ),
  );
}
/**
* Implements hook_field_formatter_view().
*/
function custom_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();
  // we know we should only have a single item
  if (isset($items[0]['registration_type']) && !empty($items[0]['registration_type'])) {
    $reg_type = registration_type_load($items[0]['registration_type']);
    $settings = $display['settings'];
    $label = !empty($settings['label']) ? $settings['label'] : $reg_type->label;
    if ($display['type'] == 'custom_registration_form') {
      $account = $GLOBALS['user'];
      list($entity_id) = entity_extract_ids($entity_type, $entity);
      // If the user is already registered, display a link to edit the resgitration
      if ($registration_id = _custom_registration_is_registered_id($entity_type, $entity_id, NULL, $account->uid)) {
        $registration = entity_load_single('registration', $registration_id);
        $registration_states = registration_get_states_options();
        //Get current event URL to use for destination after editing the registration link
        if (arg(0) == 'node' && is_numeric(arg(1))) {
          // Get the nid
          $nid = arg(1);
          $query_string = array('destination' => 'node/'.$nid);
        }else{
          $query_string = array();
        }
        
        $element[0]['link'] = array(
          '#markup' => t('You already registered for this event. <a href="@url">Edit your registration</a>.' . "\n",
            array('@state' => $registration_states[$registration->state], '@url' => url('registration/' . $registration_id . '/edit', array('query' => $query_string)))),
          '#prefix' => '<p>',
          '#suffix' => '</p>',
        );
      }
      // If the user can access the registration, show the form only if the event is not full
      elseif ($registration_access = registration_register_page_access($entity_type, $entity)) { // && registration_status($entity_type, $entity_id)
        if (registration_status($entity_type, $entity_id)) {
          $registration = entity_get_controller('registration')->create(array(
            'entity_type' => $entity_type,
            'entity_id' => $entity_id,
            'type' => $reg_type->name,
          ));
          $element[0]['form'] = drupal_get_form('registration_form', $registration);
        }
        else {
          $element[0]['form'] = array(
            '#markup' => t('Registrations are no longer available for %name.',
              array('%name' => entity_label($entity_type, $entity))),
            '#prefix' => '<p>',
            '#suffix' => '</p>',
          );
        }
      }
      // Check whether the entity has any registration enabled
      $settings = registration_entity_settings($entity_type, $entity_id);
      $registration_enabled = $settings['status'];
      // Otherwise (registration open, no existing registration, no access), display another message (login link)
      if ($registration_enabled && !$registration_id && !$registration_access) {
        $element[0] = array(
          '#markup' => t('Registration is allowed for members only. Please <a href="@url">login</a> to register.',
            array('@url' => url('user/login'))),
        );
      }
    }
  }
  return $element;
}
/**
* Determine if a person has an active registration for a host entity.
* modified from registration_is_registered(Registration $registration, $anon_mail = NULL, $uid = NULL, $states = array())
*
* A person may be Drupal user account, identified by user uid ($uid).
* Or a non-user, identified by an email address ($anon_mail).
*
* One of $anon_mail or $uid is required.
*
* @param int $entity_type
*   Parent entity type
* @param int $entity_id
*   Parent entity id
* @param string $anon_mail
*   (optional) An email address.
* @param int $uid
*   (optional) A user account uid.
* @param array $states
*   (optional) An array of states to test against. Defaults to active states.
*
* @return int
*   Registration entity id
*/
function _custom_registration_is_registered_id($entity_type, $entity_id, $anon_mail = NULL, $uid = NULL, $states = array()) {
  // must provide an UID or anon_mail
  // @todo: better course of action here?
  if (!$anon_mail && !$uid) {
    return FALSE;
  }
  if (empty($states)) {
    $states = registration_get_active_states();
  }
  $query = db_select('registration', 'r')
    ->fields('r', array('registration_id'))
    ->condition('entity_id', $entity_id)
    ->condition('entity_type', $entity_type)
    ->condition('state', $states, 'IN');
  if ($anon_mail) {
    // There's a user with this email, check to make sure they're not registered.
    if ($user = user_load_by_mail($anon_mail)) {
      $query->condition(db_or()->condition('anon_mail', $anon_mail)
        ->condition('user_uid', $user->uid));
    }
    else {
      $query->condition('anon_mail', $anon_mail);
    }
  }
  elseif ($uid) {
    $query->condition('user_uid', $uid);
  }
  $results = $query->execute();
  $ids = $results->fetchField();
  $id = ($ids=='' ? 0 : $ids);
  return $id;
}
igorik’s picture

would be great to have this directly added into the module

peter.morlion’s picture

Wouldn't it be better to not hide the form entirely, but instead how a message stating the user has already registered and have a button to unregister? I believe this would be a better UX, as everything is available on one page.

I find it weird that to register, you can do it on the main page, but to unregister, there's a separate page.

igorik’s picture

Yes, this can be better solution, to show registered user this form
but only with Unregister button, nothing more.

imclean’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Needs work
FileSize
5.15 KB

A work in progress, this only applies to the "Registration Link" display option, not the form at this stage.

  • Adds a "Cancel label" option to the Registration Link field formatter settings (although it actually deletes the registration)
  • If a logged in user is already registered, the cancel label will display with a link to delete the registration
  • An unrelated feature was was added: the ability to add options to the registration link. In this case, I've added the destination query to the delete link. This should probably be a separate feature request.

No permission checks are done before displaying the cancel label, the link simply won't work if the user doesn't have permission.

It really should include the option to display some text instead of the Cancel button, perhaps using a dropdown in the field formatter settings: "Show cancel link", "Show already registered text".

Or the patch could simply be modified to suit the use cases above.

imclean’s picture

Improved version of #25, this provides 3 options for what to display to users who are already registered.

The options within the display formatter for the registration link are to display:

  1. The registration link (default, current behaviour)
  2. Registered text (e.g. You have already registered for this event)
  3. Cancel link (deletes the registration)
imclean’s picture

Status: Needs work » Needs review

Review progress thus far.

igorik’s picture

souds amazing, looking forward to test it!

cboyden’s picture

It would be better to change your wording to "delete" everywhere you have "cancel." Otherwise it won't be sufficiently clear that the registration will be completely gone, as opposed to in a canceled state where someone could un-cancel it if they needed.

Also, it would be nice to have a link to the registration edit form on the registered text option.

imclean’s picture

#29, "Delete" would make more sense.

Also, it would be nice to have a link to the registration edit form on the registered text option.

This should probably be a separate option, "Edit Link".

igorik’s picture

Hello,
I tried to test it with latest registration.module (1.5 and later 1.x) but I found that big part of the patch #16 is already included,
so is this functionality now in the module?

I really don't remember how it was before, I am just preparing myself for using Entity registration module.

Now I can see the fieldset My registration
with information about my registration and with Delete link.

When I canceled my registration, I can see on the page link Registration: Registration[link]

If it is not the full feature from the patch, can please somebody update the patch for latest module version?

Thanks
Igor

imclean’s picture

Based on #26, the Registration Link display formatter now includes:

  • Already registered text
  • Edit Registration link
  • Delete registration link

@igorik, this needs review before it can be included. It is a change to the display formatter for "Registration Type" field, "Registration Lin" option. The registration itself already includes options to edit and delete a registration.

@cboyden, can you please review.

igorik’s picture

Hello Imclean,
I used your patch with Entity Registration 1.5 and I can confirm that
there are now 4 working options under Manage display -> Registration field.
Register link OR Registered text OR Edit link OR Delete link

Igor

igorik’s picture

Hello,
I am using registration form disoay format (not Registration link) for Registration field on the node page.
Is there any chance, how I can show "you are already registered" to registered member?
Now there is the form for unregistered member to the event, and after registration to the event, there is no form (what is ok) but no other text like "you are already registered" and ideally + links to edit, delete and view his registration.

imclean’s picture

Please feel free to develop this patch further. It would also be handy to have more people review and provide feedback.

It is working well for our needs and I have little time to develop it further at this stage. I will make changes to the existing function based on constructive feedback.

Anonymous’s picture

I applied this patch and it seems to work except when I test it with a user with normal permissions the 'Already Registered' state doesn't show up whatsoever. I can set it up so when I register I see a 'Edit Registration' link logged in as admin but a user without at least the 'Registertype: Administer settings' permission has the register field disappear.

I can't think of anything obvious that's causing his behavior

mahammedzkhan’s picture

Just make sure the 'pending' state is active under 'registration states':
admin/structure/registration/registration_states

SocialNicheGuru’s picture

does not apply to dev version cleanly

joelpittet’s picture

@SocialNicheGuru re #38 it seems to work against 7.x-1.x-dev cleanly, are you on the same branch?

asrob’s picture

Status: Needs review » Reviewed & tested by the community

RTBC'ed based on joelpittet's comment.

Anybody’s picture

Any plans for a new dev release containing this patch?

nmillin’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
8.25 KB

Patch from 32 is missing

-                'path' => $uri['path'] . '/register',
+                'path' => $path,

from patch 25.

Attaching updated version of 32 with this in it. Setting back to needs review for the new patch to be reviewed.

joelpittet’s picture

@asrob I would have RTBC'd it if I thought so, that RTBC is on you;)

asrob’s picture

Status: Needs review » Reviewed & tested by the community

@joelpittet, I agree, looks good to me. :)

Bruno Nery’s picture

Waiting list, someone was able to let the waiting list receive only one record. The way the module is currently I can register on the waiting list more than once with the same user.
Would it be nice to only receive one record per user, did any of the friends come across this problem?

Bruno Nery’s picture

Title: Hide registration form for already registered users » Wait List
imclean’s picture

Title: Wait List » Hide registration form for already registered users
Bruno Nery’s picture

joelpittet’s picture

Status: Reviewed & tested by the community » Needs review

@todo: better course of action here?

What should be done with this @todo?

There are a few coding standard faux pas in there to clean up around spaces of the ==, didn't look too close on the nitpiks but worth a clean up

Bensbury’s picture

I'm trying to review the patch from #42 but I get this error:
patch: **** malformed patch at line 133: diff --git a/registration.module b/registration.module

I've used the patch -p1 and git command way. Does anyone else get this error?
If not is there a certain way to make the patch work? Otherwise I guess it fails.

Thanks