Does not work with PHP7 due to is_numeric no longer accepting hex numbers [#2835090]

Strings in hexadecimal (e.g. 0xf4c3b00c) notation are no longer regarded as numeric strings, i.e. is_numeric() returns FALSE now.

so the decoding from referal code to uid fails, due to the check in _referral_ref2uid().

It can be fixed without altering the intended functionality by changing the check to ctype_xdigit($ref) (http://php.net/manual/en/function.ctype-xdigit.php)

Comment	File	Size	Author
#2	hex_string_numeric_check_for_php7-2835090-2.patch	398 bytes	s.messaris

Comments

13 December 2016 at 13:45

s.messaris commented 13 December 2016 at 13:47

Status	File	Size
new	hex_string_numeric_check_for_php7-2835090-2.patch	398 bytes

owenbush commented 30 March 2017 at 21:40

I can confirm this is an issue with PHP7 and patch #2 worked for me.

3cwebdev commented 7 June 2017 at 19:49

Patch #2 worked for me on PHP 7.0. Thanks!

royerd commented 13 June 2019 at 11:25

Patch works for me. Without this, the referral link will not set the cookie.