Problem/Motivation

We need full views integration.
Admin pages and reports should also use views.

Remaining tasks

Basic Views integration has been done.
But admin pages and reports, etc... are not using views yet.
We should convert all reports to views.

List of functions that need to be converted to views:

  • referral_admin_view_details()
  • referral_admin_view_unflagged()
  • referral_admin_view_roles()
  • referral_admin_view_summary()
  • referral_block_content()
  • referral_view() - Default views created. TODO: Test it and if it's OK, redirect referral/view to the views page: 'my-referrals'

User interface changes

If we delete old URLS, and replace them with views, some urls such as ''referral/view" will become unavailable.

CommentFileSizeAuthor
#17 referrals-views-integration-1792720-17-D7.patch9.34 KBhejazee
#13 interdiff-1792720-12-13.txt674 bytesmrded
#13 referral-1792720-13.patch4.56 KBmrded
#12 referral-1792720-12.patch4.53 KBmrded
#12 interdiff-1792720-3-12.txt8.73 KBmrded
#9 interdiff-1792720-3-9.txt12.4 KBmrded
#9 referral-1792720-9.patch8.55 KBmrded
#3 referral-views_integration-1792720-2.patch5.54 KBjosebc
#1 referral-views_integration-1792720-1.patch4.73 KBjosebc

Comments

josebc’s picture

josebc commented
StatusFileSize
new referral-views_integration-1792720-1.patch4.73 KB
qasimzee’s picture

qasimzee commented

is it ready?

josebc’s picture

josebc commented
StatusFileSize
new referral-views_integration-1792720-2.patch5.54 KB

you can apply this file against 7.x-1.x-dev

drone.ah’s picture

drone.ah commented

patch applies cleanly and works as advertised...

Is it worth checking if the entity api module is available and passing off the views integration to that since it does all of it fairly automatically...?

josebc’s picture

josebc commented
Status: Needs work » Needs review

we would still need to add the relations to the views data so i don't think this step will be really important

josebc’s picture

josebc commented
Issue summary: View changes
paul.moloney’s picture

paul.moloney commented

The patch from #6 is working well for me. It would be good to include flag support too.

mrded’s picture

mrded commented
Status: Needs review » Needs work

I've checked #3 patch and there are a few things I noticed:

  • I don't understand you why do you need to wrap 'referral' table with an entity. Moreover you cannot use 'uid' as a key, because it's not unique
  • With current implementation of integration, there is no way to get invited users if base table is 'users'. You must always use 'referral' as a base table.
  • Based on 'referral' schema 'uid' points on the user who was invited. In your patch it points the referral user
  • Why do you use these extra fields 'created_fulldate', 'created_year_month' and 'created_year', 'created_month' and 'created_day' if you can apply a formatter for 'created' field?
  • integration with 'flag_timestamp' and 'flag' fields is missing
mrded’s picture

mrded commented
Status: Needs work » Needs review
StatusFileSize
new referral-1792720-9.patch8.55 KB
new interdiff-1792720-3-9.txt12.4 KB

Please, take a look at a new version of the patch. I've also included an example of a view.

mrded’s picture

mrded commented
Assigned: josebc » Unassigned
mrded’s picture

mrded commented

I'm sorry, @josebc just read you patch more carefully. It makes more sense now. Ignore my previous patch.

mrded’s picture

mrded commented
StatusFileSize
new interdiff-1792720-3-12.txt8.73 KB
new referral-1792720-12.patch4.53 KB

Please take a look new version of a patch.
I've cleaned it up a bit and added an integration with 'flag_timestamp' and 'flag' fields.

mrded’s picture

mrded commented
StatusFileSize
new referral-1792720-13.patch4.56 KB
new interdiff-1792720-12-13.txt674 bytes

Just a few small fixes.

destinationsound’s picture

destinationsound commented

A Few things. First of all, #13 works without any issues.

Second, Will this allow me to create a Views Block with the users unique code, so I can place it anywhere on the site? If not, how can i get that option?

josebc’s picture

josebc commented

@mrded , can you please explain what changed from patch in #3?

hejazee’s picture

hejazee commented
Assigned: Unassigned » hejazee
Issue summary: View changes
Status: Needs review » Needs work

I'm working on this module and changing many things.
I will add full views integration for the next release of this module.

Thanks for your patches.
However since the source of this module is being changed significantly, some patches may need re-creation.

Another thing: Why do you add entity hooks for this module in your patches?
It is not necessary for this module to use entities. nor for views integration.

hejazee’s picture

hejazee commented
StatusFileSize
new referrals-views-integration-1792720-17-D7.patch9.34 KB

I have created a new patch with full views integration. This is the same as #13, but with a little modification and also support for other fields and more.
I will push it.

Extended views integration will come soon. (Issue status will still remain "Needs work")

  • hejazee committed b58fc57 on 7.x-1.x 
    Issue #1792720 by mrded, josebc, hejazee: Views Integration
hejazee’s picture

hejazee commented
Issue summary: View changes

Updated issue summary.

hejazee’s picture

hejazee commented
Issue summary: View changes

Updated issue summary

  • hejazee committed 060bcd7 on 7.x-1.x 
    Issue #1792720 by hejazee: Views Integration: Added default view for My...
hejazee’s picture

hejazee commented
Issue summary: View changes

Added default view for My referrals page. (Address: my-referrals)
Added a block: a list of my referrals.

socialnicheguru’s picture

socialnicheguru commented

should this be closed? if so why didn't the system close it?

hejazee’s picture

hejazee commented

@SocialNicheGuru, Please see the issue summary.