Right now, the main info file for Redirect declares core_version_requirement of ^8.8 || ^9. That's all well and good, but the info files for the redirect_404 and redirect_domain submodules declare ^8.7.7 || ^9.

In theory, this isn't a problem. But the devil is potentially in the details -- when working on CTools, I was told by its maintainers that mixing core version requirements like this is potentially dangerous. What exactly happens when you mix version constraints is unclear, but since we might want to take a "better safe than sorry" approach here, I propose we use the same core_version_requirement for all info files.

CommentFileSizeAuthor
#2 3132121-2.patch1018 bytesphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3132121-2.patch1018 bytes

Patch for this. Hopefully it passes on all supported core versions.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, it did in fact not pass on 9.0 but that's not the fault of this patch.

  • Berdir committed 3a0405d on 8.x-1.x authored by phenaproxima 
    Issue #3132121 by phenaproxima: Make core_version_requirement consistent...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.