63/63 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------------------------------------------------------------------------------------------
Line modules/redirect_404/src/EventSubscriber/Redirect404Subscriber.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------
102 Parameter $event of method Drupal\redirect_404\EventSubscriber\Redirect404Subscriber::onKernelException() has typehint with deprecated class
Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:
since Symfony 4.3, use ExceptionEvent instead
104 Call to deprecated method getException() of class Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:
since Symfony 4.4, use getThrowable instead
------ ----------------------------------------------------------------------------------------------------------------------------------------------
Line modules/redirect_domain/src/EventSubscriber/DomainRedirectRequestSubscriber.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
68 Parameter $event of method Drupal\redirect_domain\EventSubscriber\DomainRedirectRequestSubscriber::onKernelRequestCheckDomainRedirect() has typehint with deprecated class
Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead
112 Parameter $event of method Drupal\redirect_domain\EventSubscriber\DomainRedirectRequestSubscriber::setResponse() has typehint with deprecated class
Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/EventSubscriber/RedirectRequestSubscriber.php
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
111 Parameter $event of method Drupal\redirect\EventSubscriber\RedirectRequestSubscriber::onKernelRequestCheckRedirect() has typehint with deprecated class
Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead
180 Parameter $event of method Drupal\redirect\EventSubscriber\RedirectRequestSubscriber::setResponse() has typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/EventSubscriber/RouteNormalizerRequestSubscriber.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------
86 Parameter $event of method Drupal\redirect\EventSubscriber\RouteNormalizerRequestSubscriber::onKernelRequestRedirect() has typehint with deprecated class
Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3130096-7.patch | 12.53 KB | askibinski |
Comments
Comment #2
kapilv commentedComment #4
saphemmy commentedThe issues have been fixed as stated above
Comment #6
saphemmy commentedMost of these tests were already failing before my patch.
Comment #7
askibinski commented@saphemmy The tests still used the deprecated classes as return types which conflicts.
Comment #8
holist commentedFixes deprecation notices. Works best when combined with https://www.drupal.org/project/redirect/issues/3173618, with both changes I got no more deprecation notices for the module.
Comment #9
berdirThis means the module then requires Drupal 9, which is fine, but all info.yml files and composer.json need to be updated to reflect that.
Comment #11
berdirChange of plan, I'll do that in #3271749: Require Drupal 9 and remaining test deprecations