Support redirect entity for Feeds.
Patch will be attached

CommentFileSizeAuthor
#14 redirect-feeds-target-3046873-14.patch1.08 KBphergo
#12 redirect-feeds-target-3046873-12.patch1.08 KBphergo
#9 feeds_redirect_unique_source.png20.96 KBscotwith1t
#2 redirect-feeds-target-3046873-1-8.patch1.02 KBartematem

Issue fork redirect-3046873

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

artematem created an issue. See original summary.

artematem’s picture

artematem commented
Status: Active » Needs review
StatusFileSize
new redirect-feeds-target-3046873-1-8.patch1.02 KB
jesss’s picture

jesss commented
Status: Needs review » Needs work

This seems like an essential piece of the puzzle -- how can you import a redirect without the source?

That said, this patch is in the wrong namespace, so it throws errors. This patch is for the Feeds module, so the namespace should be namespace Drupal\feeds\Feeds\Target; not namespace Drupal\redirect\Feeds\Target;. Or, it should be reworked to patch the Redirect module instead.

damondt’s picture

damondt commented
Status: Needs work » Reviewed & tested by the community

The namespace namespace Drupal\redirect\Feeds\Target; is correct, this works without issue.

kleiton_rodrigues’s picture

kleiton_rodrigues commented

The patch applies cleanly and works as expected.
RTBC+1

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: kleiton_rodrigues » Unassigned
scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

+1 thanks!

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented
StatusFileSize
new feeds_redirect_unique_source.png20.96 KB

How do we avoid the duplication warnings when re-running the same feed if the (for example csv file) source has been updated? 

Warning message
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'HJN0C2ixrt8oFOjq6MHmQsJbrjWYsh6wq_iM2fL3E4w' for key 'hash': INSERT INTO "redirect"

Since the "from" in a redirect is only allowed to go to one "to" destination, it would make sense to be able to select the redirect_source as Unique in the fields UI.
feeds redirect unique source

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

Assigning to myself as I'm triaging all RTBC issues.

jpshayes’s picture

jpshayes commented

Did this patch make it into the latest dev branch? I have a need for this and I am happy to test or help if it is needed.

phergo’s picture

phergo commented
StatusFileSize
new redirect-feeds-target-3046873-12.patch1.08 KB

I have added the option to set the "redirect_source/path" property as unique in order to avoid duplication warnings.

phergo’s picture

phergo commented
phergo’s picture

phergo commented
StatusFileSize
new redirect-feeds-target-3046873-14.patch1.08 KB

Patch #14 adds the ability to mark the "redirect_source/path" property as unique in order to avoid duplication warnings.

hswong3i made their first commit to this issue’s fork.

hswong3i opened merge request !113

hswong3i’s picture

hswong3i commented

Convert to MR, rebase with 8.x-1.x-dev

megachriz’s picture

megachriz
Primary language Dutch
commented

Closed #3532139: Feeds: Add support for redirect_source field types as a duplicate.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned

The AI initiative has consumed me so unassigning

berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

This will need to handle phpstan, probably by adding feeds as a dev dependency or ignoring those errors.