I tried it with PHP 7.2 and I get the follwing:

Fatal error: Declaration of RedhenOrgEntityController::save($org) must be compatible with EntityAPIController::save($entity, ?DatabaseTransaction $transaction = NULL) in /www/htdocs/example.com/sites/all/modules/redhen/modules/redhen_org/lib/redhen_org.controller.inc on line 88

CommentFileSizeAuthor
#6 interdiff-2937481-3-6.txt536 bytessamuel.mortenson
#6 2937481-6.patch1.22 KBsamuel.mortenson
#3 2937481-3.patch570 bytesmnordstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Donit created an issue. See original summary.

sahaj’s picture

sahaj CreditAttribution: sahaj commented

Any idea how to solve this?

mnordstrom’s picture

mnordstrom CreditAttribution: mnordstrom for Mediamaisteri Oy commented
FileSize
2937481-3.patch570 bytes

Error solved with the patch attached.

gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Status: Active » Reviewed & tested by the community
johnhanley’s picture

johnhanley CreditAttribution: johnhanley as a volunteer commented

The same is true for redhen_relation_role.controller.inc:

Fatal error: Declaration of RedhenRelationRoleEntityController::save($relation_role) must be compatible with EntityAPIControllerExportable::save($entity, ?DatabaseTransaction $transaction = NULL) in /www/htdocsl/example.com/sites/all/modules/redhen/modules/redhen_relation/lib/redhen_relation_role.controller.inc on line 27

Line 22 Before:

public function save($relation_role) {

Line 22 After:

public function save($relation_role, DatabaseTransaction $transaction = NULL) {

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Reviewed & tested by the community » Needs review
FileSize
2937481-6.patch1.22 KB
interdiff-2937481-3-6.txt536 bytes

Addressed #5

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

  • gcb committed 2334720 on 7.x-1.x authored by samuel.mortenson 
    Issue #2937481 by samuel.mortenson, mnordstrom: Fatal error with PHP 7.2
gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Status: Reviewed & tested by the community » Fixed

thanks all! This is committed and will be in the next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.