Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently redhen_dedupe module works only for contacts. Would be good to extend it for organizations as well.
I will try to provide a patch
Comment | File | Size | Author |
---|---|---|---|
#9 | redhen_dedupe_org-2354249-9.patch | 20.26 KB | a.milkovsky |
Comments
Comment #1
a.milkovskyI added 2 new menus:
Also I made form callback
redhen_dedupe_merge_form()
more generic to work with different entity types.Comment #2
fagoI think this should better throw an exception as this can happen only when developers use the functon wrong.
Also, it should document which entities this can work with at the function docblock.
Comment #3
a.milkovskyGood catch, thanks. I will change patch tomorrow
Sorry, I didn't get it :)
Comment #4
fagoAlso, it should document which entities this can work with at the function docblock.<?php
The code works only with entities provided by the entity api, i.e. using entity classes - right? So this should be documented then.
Comment #5
a.milkovskyUpdated the patch.
I also added new hook that allows modules to act before values merge from records into master record: hook_redhen_dedupe_entity_merge
Comment #6
fagothanks, changes are good. Also, +1 on adding this hook - we need to allow other related modules to properly respond to a merge. I think it would be cleaner to move all the redhen related modules responding code to their respective modules as well, but that clean-up could happen in a follow-up.
We are using this patch on a client site now, it works fine - thus RTBC.
Comment #7
levelos CreditAttribution: levelos commentedThanks guys, this would be a great addition. Couple of problems. First, the patch doesn't apply cleanly as it's root is full path to the site of the user who authored it rather than the module. More importantly, there is no interface or menu item to access the organizational deduping.
redhen/dedupe
is just for contacts as it stands. That should be refactored to offer access to dedupe contacts or orgs and then direct to the appropriate deduping form.Comment #8
a.milkovskyThere are 2 in the patch:
I will fix that
Comment #9
a.milkovskyUpdated the patch
Comment #10
chertzogHas there been any additional work on this?
Comment #11
a.milkovskyActually the patch is finished and ready-to-use. We are using it already in production since 1 year already.
You can review the patch and set it to RTBC, if it works for you.