Problem/Motivation
The functionality for sending multiple reminders for an event (by updating the reminder settings in the event series, for example, initially scheduling a reminder for "1 month before" and later adding a new reminder for "1 day before") was introduced at #3283237.
While this feature is useful, an important aspect appears to have been overlooked: only future event instances should be marked for sending new reminders.
Currently, if a series contains both past and future instances, and the reminder settings are changed, reminder notifications are sent to registrants of past instances as well. This can cause confusion and potentially serious problems for users.
Steps to reproduce
- Edit a series with some instances in the past and others in the future.
- Change the reminder settings for the series.
- Run cron.
- Result: Registrants of past instances receive new reminder notifications, even though those events have already occurred.
Proposed resolution
- Check the instance date.
- Only re-enable reminders for future instances.
- Skip any instances scheduled in the past.
Remaining tasks
Get the MR reviewed and merged.
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork recurring_events-3545215
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
camilo.escobar commented