Problem/Motivation

As of Drupal 10.1, core provides a generic entity revision UI (change record , #2350939: Implement a generic revision UI). Please consider adopting this instead of the current custom implementation.

Benefit: Besides eliminating several forms and controller methods that would no longer need to be maintained, it would allow the Revisions tabs on events to look and act the same as those found on core entity types, like nodes. It also sets up Recurring Events to benefit from efforts underway in the Diff module to provide a generic "compare revisions" feature for all content entity types, once #2452523: Offer a revisions tab for all entities is resolved.

Proposed resolution

Replace the custom revision UI routes/forms currently implemented with those now available in core.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork recurring_events-3544748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

muriqui created an issue. See original summary.

muriqui opened merge request !172

muriqui’s picture

muriqui commented
Status: Active » Needs review

muriqui opened merge request !201

muriqui’s picture

muriqui commented
Version: 2.0.x-dev » 3.0.x-dev
chrisla’s picture

chrisla commented

Will this update preserve any previously saved revisions?

muriqui’s picture

muriqui commented

@chrisla Yes. It doesn't affect the revisions themselves at all. It's just swapping out the user interface for managing revisions: removing the custom UI currently provided by the module and replacing it with the standard UI now provided by Core (which pretty much does the same thing, and is supported by other modules, such as Diff).

muriqui closed merge request !172

eric.napier’s picture

eric.napier commented
Status: Needs review » Reviewed & tested by the community

Tested in an integration environment with Recurring Events enabled. Fix works as expected and code reviewed for standards / best practice.

  • muriqui committed 1d31ab31 on 3.0.x 
    feat: #3544748 Adopt core's generic revision UI

By: muriqui
By: eric....
muriqui’s picture

muriqui commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.