Problem/Motivation

Commit 8fe75abb included several fixes for issues reported by phpcs, including changing true/false to TRUE/FALSE. Unfortunately, that change was also applied to recurring_events_create_form.js, causing an error because TRUE and FALSE are not recognized keywords in JavaScript

Steps to reproduce

  1. Open your browser's JS console.
  2. Go to the event creation form (/events/add/default).
  3. Select "Weekly" recurrence.
  4. Set the start date.

Result: Console reports Uncaught ReferenceError: FALSE is not defined

Proposed resolution

Revert FALSE to false and TRUE to true in js/recurring_events_create_form.js.

Issue fork recurring_events-3541224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

muriqui created an issue. See original summary.

muriqui opened merge request !164

muriqui’s picture

muriqui commented
Status: Active » Needs review
dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Confirmed the update fixes the JS error. Thank you @muriqui

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Reviewed & tested by the community » Postponed

Thanks for working on this! Unfortunately this can't be merged as long as the tests are not passing. Postponing on #3541906: Tests are failing in 2.0.x.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Postponed » Reviewed & tested by the community

#3541906: Tests are failing in 2.0.x has been merged, restoring previous status.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

  • pfrenssen committed 7153b203 on 2.0.x authored by muriqui 
    Issue #3541224 by muriqui, dmundra: Invalid boolean values in...
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot for the fix!

  • pfrenssen committed 7153b203 on 3.0.x authored by muriqui 
    Issue #3541224 by muriqui, dmundra: Invalid boolean values in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.