It turns out that the URLs being passed around are in different formats. This is causing errors as some methods are expecting Urls and others are expecting strings. Included in this problem is the original report below, where the billing-update URL is incorrect, but it makes sense to fix all of these problems at once.

Original issue

This is a follow-up to #2869882: recurly_hosted account manage url returns 404. The URL for this was set there, but it was set incorrectly. It's missing an /edit at the end, as per Hosted Billing Information in the docs.

Patch forthcoming.

CommentFileSizeAuthor
#11 recurly-fix_hosted_url_mismatches-2973143-11.patch410 bytesmarkdorison
#8 interdiff-2973143-5-8-do-not-test.diff693 bytescolan
#8 recurly-fix_hosted_url_mismatches-2973143-8.patch5.01 KBcolan
#5 interdiff-2973143-3-5.do-not-test.diff4.1 KBcolan
#5 recurly-fix_hosted_url_mismatches-2973143-5.patch5.05 KBcolan
#3 recurly-update_billing_info_url_wrong-2973143-3.patch1.2 KBcolan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Issue summary: View changes

Added link to docs.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Active » Needs review
FileSize
recurly-update_billing_info_url_wrong-2973143-3.patch1.2 KB

Patch attached.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Title: Recurly Hosted's "Update billing information" URL returns 404 » Recurly Hosted's URLs are mismatched
Issue summary: View changes
Status: Needs review » Needs work

Added greater scope to IS.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs work » Needs review
FileSize
recurly-fix_hosted_url_mismatches-2973143-5.patch5.05 KB
interdiff-2973143-3-5.do-not-test.diff4.1 KB

See attached.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Title: Recurly Hosted's URLs are mismatched » Recurly Hosted's URL formats are mismatched
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Needs work

Changes look good except for one code item below.

+++ b/modules/recurly_hosted/recurly_hosted.module
@@ -19,35 +20,27 @@ function recurly_hosted_recurly_url_info($operation, $context) {
+      $settings_raw = (new RecurlyEntityTypeInfo(\Drupal::configFactory()))->getUserInfoMappings();

The recurly.entity_type service should be used to instantiate this class instead of calling it with "new" directly. See recurly.module for an example.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs work » Needs review
FileSize
recurly-fix_hosted_url_mismatches-2973143-8.patch5.01 KB
interdiff-2973143-5-8-do-not-test.diff693 bytes

How's this?

  • markdorison committed 949a74c on 8.x-1.x authored by colan 
    Issue #2973143 by colan: Recurly Hosted's URL formats are mismatched
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Fixed
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Fixed » Needs review
FileSize
recurly-fix_hosted_url_mismatches-2973143-11.patch410 bytes 
+++ b/modules/recurly_hosted/recurly_hosted.module
@@ -10,6 +10,7 @@
+use Drupal\recurly\RecurlyEntityTypeInfo;

I missed this in my initial review, but this use statement was added but is no longer needed.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Reviewed & tested by the community

Good catch!

  • markdorison committed 4cda8e8 on 8.x-1.x 
    Issue #2973143 by colan, markdorison: Recurly Hosted's URL formats are...
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.