I could very well be missing things so let's add those too, but I noticed:

Important: This version of the Recurly module is only compatible with Recurly.js v3 (see v4 issue) and the Recurly v2 API.

We're now using v4.

Also, we should add that the new Access Recurly subscription pages permission should be enabled for users to see/manage their subscriptions.

CommentFileSizeAuthor
#13 some_readme_md-2872490-13-7x-3x.patch2.59 KBwalangitan
#11 some_readme_md-2872490-11-7x-3x.patch2.67 KBwalangitan
#5 interdiff-2872490-2-5.txt1.33 KBmarkdorison
#5 some_readme_md_updates-2872490-5.patch2.43 KBmarkdorison
#2 recurly-update_readme-2872490-2.patch2.79 KBcolan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Active » Needs review
FileSize
recurly-update_readme-2872490-2.patch2.79 KB
Aanal.addweb’s picture

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Needs work

@colan, Thanks for the patch but i think it should be as per the standard format. which mentioned in : https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs work » Needs review

Can we deal with formatting in a separate issue? I'm simply trying to add missing information and fix incorrect information here.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
FileSize
some_readme_md_updates-2872490-5.patch2.43 KB
interdiff-2872490-2-5.txt1.33 KB
  1. Fixed a couple of spacing issues.
  2. Fixed line exceeding 80 characters.
  3. Rewrote permissions step.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Reviewed & tested by the community

Works for me.

  • markdorison committed 1a8ce83 on 8.x-1.x authored by colan 
    Issue #2872490 by markdorison, colan: Some README.md updates are...
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 8.x-1.x-dev » 7.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

I think the 7.x-3.x README could benefit from some of this patch.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Assigned: colan » Unassigned
walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic commented
Assigned: Unassigned » walangitan

I'll put up a patch including this in the 7.x branch.

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic commented
Status: Patch (to be ported) » Needs review
FileSize
some_readme_md-2872490-11-7x-3x.patch2.67 KB
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Needs work 
+++ b/README.txt
-- While on the Recurly settings page in Drupal, copy the full URL from the
+   available. Take this full URL and paste it into the Recurly.com settings for
+   "Endpoint URL" - Developers > Webhooks > Webhook Endpoints at
+   "configuration/endpoints". If no endpoints are configured, configure a new
+    webhook endpoint at "configuration/endpoints/new", using the
+    same "Listener URL key" field.

The indentation in this section increases as the lines move on and seems to be off compared to the other sections.

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic commented
Status: Needs work » Needs review
FileSize
some_readme_md-2872490-13-7x-3x.patch2.59 KB

This should fix the issues reported in #12.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Reviewed & tested by the community

  • walangitan committed a26ebef on 7.x-3.x 
    Issue #2872490 by walangitan, markdorison, colan, dhwani.addweb: Some...
walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic commented
Assigned: walangitan » Unassigned
Status: Reviewed & tested by the community » Fixed
Aanal.addweb’s picture

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented

@walangitan, Thanks for committing the patch, but credit didn't show on my dashboard https://www.drupal.org/u/dhwaniaddweb, Can you please do the needful commit again.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented

@dhwani.addweb If the credit isn't showing up, it may be a drupal.org bug and should probably be addressed in the d.o. site issue queue. I don't think we should re-commit patches without any sense of whether it will actually resolve the issue.

Aanal.addweb’s picture

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented

@markdorison, Perhaps you were right but for providing me credit you have to tick me in credit & committing section while committing.
somehow, it is not displayed on my profile: https://www.drupal.org/u/dhwaniaddweb similar to https://www.drupal.org/u/markdorison

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic commented

@dhwani.addweb - I don't think it's warranted to add a new commit to in an attempt to resolve a credit issue here on drupal.org. I don't believe this would actually resolve the problem as the credit box for credit when generating the commit message is ticked which is what's seen in the commit message from #15. I'd echo @markdorison's suggestion for addressing this in a drupal.org issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.