The latest core updates include error messaging which can be found here. The recurly modules have an incorrect module_load_include which is causing an error to be displayed on all pages related to recurly.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

walangitan created an issue. See original summary.

walangitan’s picture

walangitan’s picture

Status: Active » Needs review
walangitan’s picture

Assigned: walangitan » Unassigned
walangitan’s picture

I forgot to add the locale module as a dependency for this patch. It's included here. We're only using it for the country list, so I'm not sure if we want to include the whole module in order to pull in that function via the module_load_include or if want to go another route. I'll post a patch below that doesn't require a new dependency.

walangitan’s picture

This patch also resolves the issue, but does not introduce a new module dependency like patch #5.

markdorison’s picture

@walangitan: #5 seems more 'best practice' than #6. Is there a precedent for the approach in #6?

If we go with #5, what does that mean for users with locale disabled?

walangitan’s picture

@markdorison: I did a check for the approach in #6 and I see that the system module does use a similar pattern to call the country_get_list() function from locale, pathauto and webform are other contrib modules that uses the include_once pattern instead of adding a dependency.

I have tried applying #5 on an installation that doesn't have locale enabled, and it maintains the same error message until I either:
1) Disable recurly and re-enable the module.
2) Enable the locale module manually.

markdorison’s picture

@walangitan: Thanks for the additional context. I am going to commit #6.

markdorison’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.