Formatting logic was moved to methods in the RecurlyFormatManager class but some of the functions still remain in recurly.module. The functions should be removed from recurly.module and any calls made to them should be update to point to the methods in the RecurlyFormatManager class.

CommentFileSizeAuthor
#4 remove_duplicated-2717611-4.patch14.15 KBmarkdorison
#2 remove_duplicated-2717611-2.patch13.65 KBmarkdorison
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Active » Needs review
FileSize
remove_duplicated-2717611-2.patch13.65 KB
  • Removed duplicated formatting logic.
  • Updated calls pointing to the recurly.module functions to point to the RecurlyFormatManager methods.

No functional changes.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Needs work
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs work » Needs review
FileSize
remove_duplicated-2717611-4.patch14.15 KB

Updated patch.

mmatsoo’s picture

mmatsoo CreditAttribution: mmatsoo at Chromatic commented

I reviewed the code and the patch applied successfully. Looks good to me.

mmatsoo’s picture

mmatsoo CreditAttribution: mmatsoo at Chromatic commented
Assigned: markdorison » mmatsoo
Status: Needs review » Reviewed & tested by the community
mmatsoo’s picture

mmatsoo CreditAttribution: mmatsoo at Chromatic commented
Assigned: mmatsoo » Unassigned

  • markdorison committed 231cc31 on 8.x-1.x 
    Issue #2717611 by markdorison, mmatsoo: Remove duplicated formatting...
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.