Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Convert RecurlyHostedRoutes to be a sub-class of RouteSubscriberBase implementing the alterRoutes method in the same way that that RecurlyRouteSubscriber is currently implemented.
Comment | File | Size | Author |
---|---|---|---|
#6 | convert_recurly_hosted-2663608-6.patch | 6.02 KB | adamzimmermann |
#6 | interdiff.txt | 2.11 KB | adamzimmermann |
#4 | convert_recurly_hosted-2663608-4.patch | 3.95 KB | markdorison |
Comments
Comment #2
colanWhat part of the model should we follow? What needs to change? I think we need a description here.
Comment #3
markdorisonUpdated issue summary.
Comment #4
markdorisonNo functional changes. Testing should consist of looking for regressions.
Comment #5
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedComment #6
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedI tested this by going directly to (/user/1/subscription/billing) and it threw an error:
Recoverable fatal error: Argument 1 passed to recurly_hosted_account_manage_url() must be of the type array, object given,
. So I checked out what was callingrecurly_hosted_account_manage_url()
and found it was passing in an object as the error claimed. So I changed the type hinting for therecurly_hosted_account_manage_url()
function.Below are the two locations that call
recurly_hosted_account_manage_url()
, and neither seem to pass in an array.Once I fixed that, this redirected successfully. However, the URL it sent me to was a 404. Is that a known issue, or am I testing this incorrectly?
The edit buttons at "/admin/config/services/recurly/subscription-plans" seem to work just fine.
Perhaps this is the issue? Should
RecurlyHostedAccountRedirectController
be callingrecurly_hosted_account_manage_url
? or should it be callingrecurly_hosted_subscription_plan_purchase_url
?Comment #7
markdorison@adamzimmermann
Did you try this on a user other than user 1? The user 1 issue may be seperate and nothing to do with this patch?Comment #8
markdorison@adamzimmermann Please ignore my previous comment.
I actually get a 404 with this patch and an exception without it. Improvement??
Comment #9
markdorisonComment #10
markdorisonComment #11
markdorisonComment #12
markdorisonI believe this patch fixes the issue at hand but has exposed a new (previously existing) issue documented in #2869882: recurly_hosted account manage url returns 404.
I am going to commit this patch and address the new bug in it's own issue.
Comment #14
markdorison