Workbench Moderation provides a fantastic example of how hooks can be abstracted into D8 services.

CommentFileSizeAuthor
#5 move_entity_hooks_to-2660066-5.patch11.5 KBmarkdorison
#4 move_entity_hooks_to-2660066-4.patch11.38 KBmarkdorison
#2 move_entity_hooks_to-2660066-2.patch11.35 KBmarkdorison
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Active » Needs review
FileSize
move_entity_hooks_to-2660066-2.patch11.35 KB

Moved entity hooks to new RecurlyEntityOperations service.

* Created RecurlyEntityOperations service.
* Moved recurly_entity_update & recurly_entity_delete logic to RecurlyEntityOperations.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Needs work
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs work » Needs review
FileSize
move_entity_hooks_to-2660066-4.patch11.38 KB

Re-rolled.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
FileSize
move_entity_hooks_to-2660066-5.patch11.5 KB

Re-rolled patch.

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented

Tested and it looks good!

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
Status: Needs review » Reviewed & tested by the community

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.