Before this was split into its own project, recipes were identified by their directory names. Now they are identified by their Composer package names. The applied recipe state is still using directory names.

Issue fork recipe_installer_kit-3507245

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

darren oh created an issue. See original summary.

darren oh opened merge request !5

darren oh opened merge request !6

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Fix recipe IDs in applied recipes state » Applied recipes state needs to store Composer package names
Status: Active » Needs review

I thought about this a bit and I realized we probably don't even need to read composer.json if we stop using the event subscriber and just add the "mark as applied" stuff as a normal batch operation. Opened !7 to propose this. What do you think - will that work? I like it most of all because it keeps everything in the Hooks class and minimizes the amount of code that a generated profile will have.

phenaproxima opened merge request !7

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Gave this a quick manual test in the context of Drupal CMS and confirmed that it works as expected (the state key contained the names of the recipes I selected at the beginning of the process).

  • phenaproxima committed 9610e089 on 1.x 
    Issue #3507245 by darren oh, phenaproxima: Applied recipes state needs...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Merged !7 into 1.x.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

I would have preferred the event subscriber because it works no matter how recipes are applied, but I can make this work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.