The help information about the module is there but it is not showing in the help page. Also make help text according to standards.

CommentFileSizeAuthor
#15 help_page_text-2858299-15.patch2.23 KBdhruveshdtripathi
#11 interdiff_8-11.txt2.76 KBdhruveshdtripathi
#11 help_page_text-2858299-11.patch2.65 KBdhruveshdtripathi
#8 help_page_text-2858299-8.patch2.28 KBdhruveshdtripathi
#3 recaptcha_help.png178.58 KBdhruveshdtripathi
#2 helppage-2858299-2.patch830 bytesPavan B S
helprecapctha.png17.28 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
helppage-2858299-2.patch830 bytes

Applying the patch, please review.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
FileSize
recaptcha_help.png178.58 KB

Patch applied and tested.

zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented
Status: Reviewed & tested by the community » Needs work
zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented

@Pavan B S, Thanks for the patch and It works well, But as per the standard format for Help page you should describe it to differentiate About and Uses of the Module.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi

Sorry, the issue was about the link on help page so I checked that only. Thank you @prafull.panchori for noticing.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Issue summary: View changes
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi as a volunteer and at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
help_page_text-2858299-8.patch2.28 KB

Changed according to standards. I understood the issue wrong earlier.

zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented
Status: Needs review » Needs work

@dhruveshdtripathi, Thanks for your quick patch but still there is a need to change the path by the actual used Breadcrumbs.
In Below mentioned section

Uses

1. Enable reCAPTCHA and CAPTCHA modules in:
admin/modules
2. You will now find a reCAPTCHA tab in the CAPTCHA administration page available at:
admin/config/people/captcha/recaptcha
3. Register your web site at
https://www.google.com/recaptcha/admin/create
4. Input the site and private keys into the reCAPTCHA settings.
5. Visit the Captcha administration page and set where you want the reCAPTCHA form to be presented:
admin/config/people/captcha
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
help_page_text-2858299-11.patch2.65 KB
interdiff_8-11.txt2.76 KB

URL links replaced with links that redirects to the page directly. I think this would be better than breadcrumb path.

zalak.addweb’s picture

zalak.addweb CreditAttribution: zalak.addweb commented
Status: Needs review » Reviewed & tested by the community

@dhruveshdtripathi, Thanks for the quickly updated patch & now it works well.

hass’s picture

hass CreditAttribution: hass commented
Status: Reviewed & tested by the community » Needs work

Very bad code.

  1. We have OL LI for html lists.
  2. Please read translatable strings documentation. There are context sensitive strings and the use of link is always wrong.
  3. Not sure why help text has been removed from admin page.
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Status: Needs work » Needs review
FileSize
help_page_text-2858299-15.patch2.23 KB

Thank you @hass for guidance. Didn't know that use of link is wrong here. I've updated the patch and used ol, li and replaced links with breadcrumb path.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

Made some changes on text and correct the incorrect HTML code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.