No option for data-callback [#2822129]

Currently there is no option to enable JavaScript call back attribute to be attached to g-recaptcha div (where all attributes get for recaptcha gets attached to) and there's no other way to do this other than modifying in recaptcha.module file itself.

Attached is patch with hard coded data-callback attribute which calls captchaCB function in global JavaScript namespace. Is it possible to add this field in settings to call different function?

Comment	File	Size	Author
#27	no-option-for-data-callback-2822129-27.patch	2.59 KB	relim
#27
#26	2822129-26-D8.patch	2.53 KB	selva.swamy@gmail.com
#26	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 3 pass
#23	2822129-23-D8.patch	2.5 KB	selva.swamy@gmail.com
#23	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 3 pass
#21	2822129-21.patch	2.5 KB	iyyappan.govind
#21	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 Patch Failed to Apply
#20	2822129-20.patch	2.5 KB	iyyappan.govind
#20	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 Patch Failed to Apply
#19	2822129-19.patch	2.55 KB	iyyappan.govind
#19	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 3 pass
#17	no-option-for-data-callback-2822129-17.patch	2.61 KB	ljcarnieri
#17	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply
#16	no-option-for-data-callback-2822129-16.patch	2.55 KB	ljcarnieri
#16	8.x-2.x: PHP 7 & MySQL 5.5, D8.7 3 pass PHP 5.5 & MySQL 5.5, D8.7 3 pass PHP 5.5 & PostgreSQL 9.1, D8.7 3 pass PHP 5.5 & SQLite 3.8, D8.7 3 pass PHP 5.6 & MySQL 5.5, D8.7 3 pass PHP 7.1 & MySQL 5.5, D8.7 3 pass PHP 7.2 & MySQL 5.5, D8.7 3 pass PHP 7 & PostgreSQL 9.1, D8.7 3 pass PHP 7 & SQLite 3.14, D8.7 3 pass
#15	recaptcha_grecaptchaCallback.patch	1.29 KB	malcolm_p
#15	8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply
#2	recaptcha_callback.patch	533 bytes	rmatsumoto
#2	8.x-2.x: PHP 5.5 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 5.5 & PostgreSQL 9.1, D8.3 3 pass, 1 fail PHP 5.5 & SQLite 3.8, D8.3 3 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 7 & PostgreSQL 9.1, D8.3 3 pass, 1 fail PHP 7 & SQLite 3.14, D8.3 3 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 October 2016 at 23:34

rmatsumoto created an issue. See original summary.

Comment #2

rmatsumoto CreditAttribution: rmatsumoto commented 25 October 2016 at 23:37

Issue summary:

View changes

File	Size
recaptcha_callback.patch	533 bytes
8.x-2.x: PHP 5.5 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 5.5 & PostgreSQL 9.1, D8.3 3 pass, 1 fail PHP 5.5 & SQLite 3.8, D8.3 3 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 3 pass, 1 fail PHP 7 & PostgreSQL 9.1, D8.3 3 pass, 1 fail PHP 7 & SQLite 3.14, D8.3 3 pass, 1 fail

Comment #3

yang_yi_cn CreditAttribution: yang_yi_cn commented 26 October 2016 at 17:57

btw this feature is regarding

You can get the user’s response in one of three ways:

g-recaptcha-response POST parameter when the user submits the form on your site

grecaptcha.getResponse(opt_widget_id) after the user completes the CAPTCHA challenge

As a string argument to your callback function if data-callback is specified in either the g-recaptcha tag attribute or the callback parameter in the grecaptcha.render method

in https://developers.google.com/recaptcha/docs/verify (Verifying the user's response).

The use case is:
- when page load the form submit button is disabled.
- only when user send the correct answer, the button will be enabled by javascript callback.

Comment #4

yang_yi_cn CreditAttribution: yang_yi_cn commented 26 October 2016 at 17:57

Status:

Active

» Needs review

Comment #5

26 October 2016 at 17:59

Status:

Needs review

» Needs work

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #6

26 October 2016 at 17:59

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #7

26 October 2016 at 18:00

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #8

26 October 2016 at 18:01

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #9

26 October 2016 at 18:01

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #10

26 October 2016 at 18:01

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #11

26 October 2016 at 18:02

The last submitted patch, 2: recaptcha_callback.patch, failed testing.

Comment #12

hass CreditAttribution: hass commented 30 January 2017 at 16:10

Maybe patch in #2847732: enable configurable data-callback attribute is a better starting point, but I'm sure it has a serious security issue.

Comment #13

hass CreditAttribution: hass commented 30 January 2017 at 16:55

onSuccess is used in https://www.google.com/recaptcha/api2/demo, but that could conflict in Drupal. We should prefix with the module name to be safe.

Comment #14

hass CreditAttribution: hass commented 30 January 2017 at 17:28

Can we do this with a Drupal.behaviors or anything else I may never used yet? So that every module can register a callback and there is no need to hardcode it?

Comment #15

malcolm_p CreditAttribution: malcolm_p commented 9 August 2017 at 19:27

File	Size
recaptcha_grecaptchaCallback.patch	1.29 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply

Here's an updated patch that adds a JS library with the callback function in the api.js to prevent the grecaptcha error. I wouldn't say this is a great solution, but I wanted the grecaptcha.getResponse() to check if a recaptcha was submitted and this allows the JS to be loaded.The callback must be in the global scope so Drupal.behaviors isn't an option.

Comment #16

ljcarnieri CreditAttribution: ljcarnieri at CI&T for CI&T commented 13 December 2018 at 10:46

File	Size
no-option-for-data-callback-2822129-16.patch	2.55 KB
8.x-2.x: PHP 7 & MySQL 5.5, D8.7 3 pass PHP 5.5 & MySQL 5.5, D8.7 3 pass PHP 5.5 & PostgreSQL 9.1, D8.7 3 pass PHP 5.5 & SQLite 3.8, D8.7 3 pass PHP 5.6 & MySQL 5.5, D8.7 3 pass PHP 7.1 & MySQL 5.5, D8.7 3 pass PHP 7.2 & MySQL 5.5, D8.7 3 pass PHP 7 & PostgreSQL 9.1, D8.7 3 pass PHP 7 & SQLite 3.14, D8.7 3 pass

I created a patch that can you configure callback in admin area, if you not fill, no one callback will be add. What do you think?

Comment #17

ljcarnieri CreditAttribution: ljcarnieri at CI&T for CI&T commented 13 December 2018 at 12:25

File	Size
no-option-for-data-callback-2822129-17.patch	2.61 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply

This patch uses the same solution, but resolve of conflict between the patch: #2493183: Ajax support / Use behaviors for version 8.x-2.3.
Motivation: I'm using the version 8.x-2.3 with this other patched applied by composer.json.

Comment #18

leofishman CreditAttribution: leofishman commented 16 April 2019 at 16:32

This may be a silly question, but the callback function should be in a global scope? I can't get reCaptcha to see it.

thanks

Comment #19

iyyappan.govind

he/him

Tamil

Chennai, India

CreditAttribution: iyyappan.govind as a volunteer and at UniMity Solutions Pvt Limited commented 8 January 2020 at 07:26

File	Size
2822129-19.patch	2.55 KB
8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 3 pass

Hi Folks, I tried to apply the #17 patch and I already applied the #2493183: Ajax support / Use behaviors for 2.x . But I got failed to apply patch.
So I rerolled the patch with the stable version of the module.

Comment #20

iyyappan.govind

he/him

Tamil

Chennai, India

CreditAttribution: iyyappan.govind as a volunteer and at UniMity Solutions Pvt Limited commented 8 January 2020 at 07:44

File	Size
2822129-20.patch	2.5 KB
8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 Patch Failed to Apply

Hi Folks uploaded wrong patch. Here is the correct one.

Comment #21

iyyappan.govind

he/him

Tamil

Chennai, India

CreditAttribution: iyyappan.govind as a volunteer and at UniMity Solutions Pvt Limited commented 8 January 2020 at 07:53

File	Size
2822129-21.patch	2.5 KB
8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 Patch Failed to Apply

The previous patch has syntax errors. Sorry for that. I updated the patch.

Comment #22

selva.swamy@gmail.com CreditAttribution: selva.swamy@gmail.com as a volunteer and commented 9 January 2020 at 06:12

Looks like there are still some issues with patch as testing failed. Kindly update and mark "Needs Review".

Comment #23

selva.swamy@gmail.com CreditAttribution: selva.swamy@gmail.com as a volunteer and commented 13 January 2020 at 08:33

File	Size
2822129-23-D8.patch	2.5 KB
8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 3 pass

Updated is the corrected patch which has been re-rolled. Also tested this feature and it is working as expected. I think after another review this issue can be marked as RTBC.