When you update a site from D6 to D7 it leaves behind a whole bunch of unnecessary variables:

  • realname_fields
  • realname_homepage
  • realname_max_username
  • realname_myacct
  • realname_nodeapi
  • realname_nofollow
  • realname_notver
  • realname_profile_module
  • realname_recalculate
  • realname_search_enable
  • realname_search_login
  • realname_theme
  • realname_user_disable
  • realname_use_title
  • realname_view

These should be removed during the upgrade.

CommentFileSizeAuthor
#1 realname-n2469383-1.patch955 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
955 bytes

This removes the unnecessary variables.

DamienMcKenna’s picture

Title: D6 variables not removed when site updated to D7 » Settings don't upgrade correctly between D6, D7

Clarified the title. It also seems that the tokens have changed, so usernames end up being e.g. "%1 %2" instead of "[user:profile-first-name] [user:profile-last-name]".

hass’s picture

Status: Needs review » Needs work

Isn't it not better to name the update hook 7001?

DamienMcKenna’s picture

@hass: *shrug*? It's the first update for v7.x-1.x of the module?

hass’s picture

A hook 7000 already exists, see http://cgit.drupalcode.org/realname/tree/realname.install#n100 . This means a lot of sites executed this already and have therefore stale variables in their database on schema version 7000. We should cleanup these sites, too and not only the sites who are still stuck at D6 and trying to upgrade.

DamienMcKenna’s picture

Status: Needs work » Needs review

Ok, it's the second update. I still don't see why we need to haggle over the number - just apply it, change the number if you want, but otherwise move along.

hass’s picture

Status: Needs review » Fixed

  • hass committed bd1eb39 on 7.x-1.x authored by DamienMcKenna
    Issue #2469383 by DamienMcKenna: Settings do not upgrade correctly...

  • hass committed bd1eb39 on 8.x-1.x authored by DamienMcKenna
    Issue #2469383 by DamienMcKenna: Settings do not upgrade correctly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.