Quoted fom 6.x documentation:

This allows you to control which roles see the realname and which don't

Request: Port for 7.x branch.

CommentFileSizeAuthor
#14 realname-permission-view-2068195-14.patch1.84 KBC-Logemann
#1 perm.patch3.33 KBNancyDru
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Active » Needs review
FileSize
perm.patch3.33 KB

Please try this patch.

sry’s picture

sry CreditAttribution: sry commented

Just made 1st test on our dev-site, works :-))

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

Thanks. I'd like to see one or two more reviews.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Patch and logic could maybe be simplified just by checking if (!user_access('view realname')) { return; } ?

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

I'm not crazy about negative logic, but yes, that might look simpler.

sry’s picture

sry CreditAttribution: sry commented

Hi,

can test on 2 other sites in the next 2-3 days, 1 environment quite similar to the first, 2nd much different (e. g. users /groups imported via LDAP). Will report ASAP.

I personally would rather keep the code 'as is' because it is working good (and probably will on other sites, too), but of course my preferences are not decisive.

CU,
Sándor

sry’s picture

sry CreditAttribution: sry commented

Hello,

just tested on 2nd site (with environment similar first test site) - works :-)

CU,
Sándor

sry’s picture

sry CreditAttribution: sry commented
Issue summary: View changes

Hello,

the solution provided by Nancy (via patch) works like a charm! But it seems not to be integrated in the 7.x-1.2 release - why?

TIA,
Sándor

hass’s picture

hass CreditAttribution: hass commented

Because You have not helped getting it ready to be committed.

sry’s picture

sry CreditAttribution: sry commented

Sorry, I'm not a coder. What kind of help should I have provided? What can I help now, regarding this issue or anywhere else?

CU,
Sándor

sry’s picture

sry CreditAttribution: sry commented

hass, I'm still awaiting a hint what I can help. Would a donation be an alternative?

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented
Status: Needs review » Needs work

@Dave Reid: Do you want this simplification for getting this committed or is this optional in your opinion? But I read between the lines of comment #9 by @hass that he is waiting on code improvements. So I change the issue status to "needs work".

Status: Needs work » Needs review

willzzz queued 1: perm.patch for re-testing.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented
FileSize
realname-permission-view-2068195-14.patch1.84 KB

Patch fixed and simplified as suggested in #4.

Status: Needs review » Needs work

The last submitted patch, 14: realname-permission-view-2068195-14.patch, failed testing.

Status: Needs work » Needs review

C_Logemann queued 14: realname-permission-view-2068195-14.patch for re-testing.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented
Version: 7.x-1.1 » 7.x-1.x-dev

Status: Needs review » Needs work

The last submitted patch, 14: realname-permission-view-2068195-14.patch, failed testing.

Status: Needs work » Needs review

C_Logemann queued 14: realname-permission-view-2068195-14.patch for re-testing.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented

Next time I will check the right code version first before submitting a patch.

hass’s picture

hass CreditAttribution: hass commented
Title: permission "use realname" in 7.x » Add permission who can see the users realname
Status: Needs review » Needs work

Please rename the participate function to something self-speaking what it does e.g module_add_default_permissions(). Better documentation would also help. A test should be added, too.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented

@hass: There aren't any tests yet and you won't accept these tiny patch if there isn't a test implemented?

hass’s picture

hass CreditAttribution: hass commented

Let's write one. Should't be that difficult and somedays we need to start writing them to prevent failures.

sry’s picture

sry CreditAttribution: sry commented

Just 4 info: Did several functional tests, no probs