Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
A scan of the module identifies some coding standards issues:
./vendor/bin/phpcs -p --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md --ignore=node_modules,vendor ./web/modules/contrib/real_aes
EWE 3 / 3 (100%)
FILE: /var/www/html/web/modules/contrib/real_aes/real_aes.install
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------
FILE: /var/www/html/web/modules/contrib/real_aes/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 81 characters
29 | WARNING | Line exceeds 80 characters; contains 84 characters
31 | WARNING | Line exceeds 80 characters; contains 85 characters
33 | WARNING | Line exceeds 80 characters; contains 87 characters
42 | WARNING | Line exceeds 80 characters; contains 81 characters
47 | WARNING | Line exceeds 80 characters; contains 83 characters
48 | WARNING | Line exceeds 80 characters; contains 88 characters
49 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------
FILE: /var/www/html/web/modules/contrib/real_aes/src/Plugin/EncryptionMethod/RealAESEncryptionMethod.php
---------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
---------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] When importing a class with "use", do not include a leading \
9 | ERROR | [x] When importing a class with "use", do not include a leading \
10 | ERROR | [x] When importing a class with "use", do not include a leading \
11 | ERROR | [x] When importing a class with "use", do not include a leading \
19 | WARNING | [ ] Line exceeds 80 characters; contains 156 characters
23 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
49 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
64 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
Issue fork real_aes-3339608
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
ptmkenny CreditAttribution: ptmkenny as a volunteer commentedThe MR fixes all issues except this one:
I don't know what the proper way is to break up an annotation description into multiple lines.
Comment #5
rlhawkI made a few additional changes and all coding standards tests pass.
Comment #7
rlhawk