Hi there!

I started adding my own vote type:

1. votingapi.vote_type.*.yml
2. hook_theme() + twig
3. hook_preprocess_HOOK()

Everything is working great with my custom type extended from fivestar but I noticed a few hard coded areas for the vote_types.

Attaching a patch for where I think we can just leverage the entityTypeManager to get the vote_types() in RateEntityVoteWidget().

CommentFileSizeAuthor
#2 hardcoded_vote_types_in-2860982-2.patch1.12 KBsylus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus created an issue. See original summary.

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
hardcoded_vote_types_in-2860982-2.patch1.12 KB
sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: hardcoded_vote_types_in-2860982-2.patch, failed testing. View results

kevin.dutra’s picture

kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commented
Status: Needs work » Closed (outdated)

This issue has been open for quite some time and the code has changed a lot since then. I don't believe that is an issue any longer, but feel free to reopen if it is. Thanks!