I made an updated README.txt file along with a patch.

CommentFileSizeAuthor
#19 read_me_2840197-19.patch1.89 KBkeshavv
#17 README-2611226-17.patch1.68 KBniyon
#16 Proof.png276.76 KBniyon
#14 README-2611226-14.patch1.68 KBniyon
#13 README-2611226-13.patch1.68 KBniyon
#11 Newreadme-2611226-11.patch1.68 KBniyon
#10 UpdatedREADME-2611226-10.patch1.32 KBniyon
#7 Newreadme-2611226-7.patch1.63 KBniyon
#4 Newreadme-2611226-5.patch1.82 KBniyon
#4 README.txt1.31 KBniyon
#2 Newreadme-2611226-5.patch1.82 KBniyon
#2 README.txt1.32 KBniyon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ninisama created an issue. See original summary.

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
README.txt1.32 KB
Newreadme-2611226-5.patch1.82 KB

Here is the patch and updated README.txt

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Active » Needs work 
  1. diff --git a/r4032login/README.TXT b/r4032login/README.TXT
index d37a747..a074483 100644

index d37a747..a074483 100644
--- a/r4032login/README.TXT

--- a/r4032login/README.TXT
+++ b/r4032login/README.TXT

    I guess the name should be changed to README.txt 

  2. +++ b/r4032login/README.TXT
@@ -1,6 +1,14 @@
+   ¶

    There's an extra space here

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
Status: Needs work » Active
FileSize
README.txt1.31 KB
Newreadme-2611226-5.patch1.82 KB

I made the necessary changes. :D

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Active » Needs work 
  1. +++ b/r4032login/README.txt
+++ b/r4032login/README.txt
@@ -1,6 +1,13 @@

@@ -1,6 +1,13 @@
+CONTENTS OF THIS FILE
+---------------------
+ * Introduction
+ * Installation
+ * Configuration
+ * Support
+ * Maintainers

    Since documentation is very short. I think we shouldn't include this piece 

  2. +++ b/r4032login/README.txt
@@ -9,15 +16,34 @@ successful, the user is taken directly where they were originally trying to go.
+Extract and enable r4032login. More documentantion at https://www.drupal.org/docs/8/extending-drupal-8/installing-contributed-modules-find-import-enable-configure-drupal-8.

    80 cols violation

I hided the Readme.txt files because they are not necessary. Please upload only the patch.

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Active
FileSize
Newreadme-2611226-7.patch1.63 KB

I think It should be fine now.
1. I removed this part
2. Fixed

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Needs review

This is the correct version.

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Needs review » Needs work 
+++ b/r4032login/README.txt
@@ -9,15 +8,35 @@ successful, the user is taken directly where they were originally trying to go.
+Extract and enable r4032login. ¶

Extra space

The patch can't be applied. Please make sure the project can be patched before submitting it for review again

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
UpdatedREADME-2611226-10.patch1.32 KB

Now the patch applied correctly ;)

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
Newreadme-2611226-11.patch1.68 KB

Updated README.txt

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
README-2611226-13.patch1.68 KB

I came up with the conclusion that this patch works and applies cleanly. But to use it you will have to rename the original README.TXT to README.txt first. Thanks :))

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
README-2611226-14.patch1.68 KB

This one works and applies perfectly!:DD

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Needs review » Needs work

The patch can't be applied. Are you working with the 8.x-1.x branch?

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
Proof.png276.76 KB

It is working on mine though..

niyon’s picture

niyon CreditAttribution: niyon at Google Code-In commented
FileSize
README-2611226-17.patch1.68 KB

With 8.x branch

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented

Tested with git and simplytest.me and patch can't be applied

keshavv’s picture

keshavv CreditAttribution: keshavv as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
read_me_2840197-19.patch1.89 KB

following drupal 8 documentation standard please review

keshavv’s picture

keshavv CreditAttribution: keshavv as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
vandna b’s picture

vandna b CreditAttribution: vandna b at gai Technologies Pvt Ltd commented
Status: Needs review » Needs work

@ keshav
when I applied your patch it gives white spacing error

  • Nixou committed 6d6403b on 8.x-1.x authored by niyon 
    Issue #2840197 by niyon, keshav.k: Updated README.txt
Nixou’s picture

Nixou CreditAttribution: Nixou at Actency commented
Status: Needs work » Fixed

Committed, thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.