My settings:

SKIP REDIRECT FOR MATCHING PAGES:
/admin/*

This settings is ignored. I am always redirect to login page.

CommentFileSizeAuthor
#8 0001-Issue-2692743-by-Leksat-szato-malcomio-mr.baileys-es.patch9.13 KBestoyausente
#7 skip-redirect-for-matching-pages.patch8.42 KBestoyausente
#5 2692743-interdiff-4-5.txt3.34 KBLeksat
#5 2692743-5.patch6.35 KBLeksat
#4 interdiff-2692743-3-4.txt1.49 KBszato
#4 list_of_pages_in_skip-2692743-4.patch5.61 KBszato
#3 r4032login-patch-matching.patch4.06 KBmr.baileys
#2 list_of_pages_in_skip-2692743-2.patch2.81 KBmalcomio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frantisekivanko created an issue. See original summary.

malcomio’s picture

malcomio CreditAttribution: malcomio at Capgemini commented
Status: Active » Needs review
FileSize
list_of_pages_in_skip-2692743-2.patch2.81 KB

Here's a patch that fixes this issue for me

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys at Calibrate commented
FileSize
r4032login-patch-matching.patch4.06 KB

Wrote a test to confirm that this functionality is indeed broken, and confirmed that after applying the patch from #2, the test passes. Patch attached contains the BrowserTest and original patch.

szato’s picture

szato CreditAttribution: szato at Brainsum for Tieto commented
FileSize
list_of_pages_in_skip-2692743-4.patch5.61 KB
interdiff-2692743-3-4.txt1.49 KB

Tested, #3 works for me.
Updated description text (D8 style path).

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Title: List of pages in SKIP REDIRECT FOR MATCHING PAGES is not working » "Skip redirect for matching pages" option exists but does not work
FileSize
2692743-5.patch6.35 KB
2692743-interdiff-4-5.txt3.34 KB

\Drupal\Core\Path\PathMatcherInterface::matchPath() expects a path as a first argument. But destination can contain language prefix, GET arguments, etc.

branram’s picture

branram CreditAttribution: branram commented

Same issue exists for the D7 version... any chance you guys can look at that?

estoyausente’s picture

estoyausente
Primary language Spanish
CreditAttribution: estoyausente as a volunteer commented
FileSize
skip-redirect-for-matching-pages.patch8.42 KB

Rerrolled!

estoyausente’s picture

estoyausente
Primary language Spanish
CreditAttribution: estoyausente as a volunteer commented
FileSize
0001-Issue-2692743-by-Leksat-szato-malcomio-mr.baileys-es.patch9.13 KB

After the reroll I tested and the code doesn't work properly, a php error was thrown (or maybe the reroll wasn't perfect). Anyway, the patch attached works as expected and can be applied!

  • Nixou committed ad71bd5 on 8.x-1.x authored by malcomio 
    Issue #2692743 by szato, Leksat, malcomio, mr.baileys: "Skip redirect...
Nixou’s picture

Nixou CreditAttribution: Nixou at Actency commented
Status: Needs review » Fixed

Sorry @estoyausente I already tested and validated the previous patch version.

Thanks you all for your work, it's now committed.

estoyausente’s picture

estoyausente
Primary language Spanish
CreditAttribution: estoyausente as a volunteer commented

No problem @nixiu, but... could you apply the patch? It thrown me some errors, for this reason I uploaded a reroll.

Edit: I applied the Lekstat patch in #5, sorry, it seems more completed but, it's ok anyway if the problem is fixed.

Nixou’s picture

Nixou CreditAttribution: Nixou at Actency commented

I don't remember if I needed to make some adjustment to apply it or if it apply directly.

Yeah the problem is now fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.