Working with https://www.drupal.org/project/quiz_item_analysis I noticed a lot of node_load() calls that were duplicate.

Here's a quick fix to avoid the db calls for the same question nodes.

CommentFileSizeAuthor
#6 2940785-6.patch1.19 KBjoelpittet
#3 2940785-3.patch1.33 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Project: Quiz item analysis » Quiz
Version: 7.x-1.x-dev » 7.x-6.x-dev
Component: Code » Code - Quiz core
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
FileSize
2940785-3.patch1.33 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
FileSize
2940785-6.patch1.19 KB

Forgot to use static for the call repeats.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented

I thought node_load() already had a static cache? Are you seeing improved performance?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented

It wouldn’t run without it and I had upped the timeout too 160 s and memory was at 512M already.

I thought it did too but that change helped a lot!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Reviewed & tested by the community

Nice patch @Joelpittet
using this patch in production, works as advertised.