Layout error quiz not starting [#2884215]

When having a full setup of quiz and submodules and adding quiz result display settings, somehow it breaks.
When quiz results cannot get a proper layout it breaks and the quiz cannot be taken because of the next error:

Notice: Undefined offset: 27 in QuizResult->getLayout() in QuizResult.class.inc
Warning: Invalid argument supplied for foreach() in quiz_take_quiz() (line 1886 in quiz.module

I think it would be nicer to set a check if there's a layout, so it cannot break the process.

Comment	File	Size	Author
#6	layout_error_quiz_not-2884215-6.patch	2.04 KB	fabianderijk
#6	7.x-5.x: PHP 5.6 & MySQL 5.5, D7 Patch Failed to Apply
#5	layout_error_quiz_not-2884215-5.patch	1.41 KB	mr_infinity
#5	7.x-5.x: PHP 5.6 & MySQL 5.5, D7 109 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 June 2017 at 21:13

mr_infinity created an issue. See original summary.

Comment #2

djdevin

Philadelphia

CreditAttribution: djdevin at Cadmium commented 6 June 2017 at 21:15

Hi,

That means the quiz attempt did not have any questions, which isn't supposed to happen.

Does it do the same if you delete the current result?

Comment #3

mr_infinity CreditAttribution: mr_infinity commented 6 June 2017 at 21:45

Thanks for the quick respond! It appears also when a newly made quiz haves questions... also when creating a new quiz. There is no possibility to start the quiz.

Comment #4

mr_infinity CreditAttribution: mr_infinity commented 6 June 2017 at 21:25

I would like to add my patch, if possible.

Comment #5

mr_infinity CreditAttribution: mr_infinity commented 6 June 2017 at 21:39

File	Size
layout_error_quiz_not-2884215-5.patch	1.41 KB
7.x-5.x: PHP 5.6 & MySQL 5.5, D7 109 pass

To bring more context: When we create a quiz, we do start the quiz automatically.
But if there are no questions, then it breaks immediatly. So if no questions where presented and you choose to start, it should not break the site.

Comment #6

fabianderijk

him/his

Dutch

Alphen aan den Rijn

CreditAttribution: fabianderijk at Finalist commented 7 June 2017 at 12:03

File	Size
layout_error_quiz_not-2884215-6.patch	2.04 KB
7.x-5.x: PHP 5.6 & MySQL 5.5, D7 Patch Failed to Apply

There was also another issue involved in this one. When you reload a quiz that you where taking (for example on the page www.example.com/node/666/take/1) and all results have been removed from that quiz (so you don't have any progress anymore) you should be redirected to the node page instead of getting a 500 error. I've added the code in the patch and uploaded it in this comment.