Quiz question admin page very slow with hidden questions [#2877760]

Hi,

Since updating from 7.x-4.0-rc2 to 7.x-4.0-rc7 I see that the admin page for a quiz question set is very slow to load. The page is located at this page node/%/questions.

I tracked down the cause to the code below from line 1347 on quiz.admin.inc:

// Fill in hidden questions block.
foreach ($hidden_questions_query->execute() as $res_ob) {
     $id = $res_ob->nid . '-' . $res_ob->vid;
     // Add $id to hidden_questions, this way quiz_questions_form knows that it has to add a invisible row for this question.
     $hidden_questions[] = $id;
}

We have around 1400 questions defined and this page takes at least 2 minutes to load.

Suggestions?

Cheers,

Matt

Comments

Comment #1

11 May 2017 at 17:10

harvlad created an issue. See original summary.

Comment #2

djdevin

Philadelphia

CreditAttribution: djdevin at Cadmium commented 6 June 2017 at 13:43

I would make the jump to 5.x when you can, this code was removed.

Comment #3

Welsby CreditAttribution: Welsby commented 18 July 2018 at 11:34

Just stumbled upon this, looks like it tries to put every question in the form so that the 'add existing question' functionality is instantanous, but this method doesn't scale well, and now we have > 3000 questions I'm hitting the php timeout as it tries to render the epic $form[].

For now I've just removed the question browser form component. Feels like this is more of a fundamental issue that requires a 5.x upgrade rather than a bug that can easily be fixed. We're using custom quiz modules so can't easily upgrade unfortunately.