Adding a UUID to this entity would allow for importing/exporting this entity across different environments - this already works for questions, pages and quizzes since they're nodes, but sadly not for the entity that bridges them.

CommentFileSizeAuthor
#13 add_uuid_to-2397863-13.patch5.33 KBanastasiaphil
#10 add_uuid_to-2397863-9.patch5.26 KBdavidraijmakers
#8 add_uuid_to-2397863-8.patch5.21 KBidebr
#8 interdiff-8-4.txt1.23 KBidebr
#4 add_uuid_to-2397863-4.patch5.94 KBFreekVR
#1 add_uuid_to-2397863-1.patch2.24 KBFreekVR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FreekVR’s picture

FreekVR CreditAttribution: FreekVR commented
FileSize
add_uuid_to-2397863-1.patch2.24 KB
FreekVR’s picture

FreekVR CreditAttribution: FreekVR commented
Status: Active » Needs review
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

That update hook won't run unless we have UUID enabled, and it won't run ever again.

Should we just require UUID module? It looks like that code might also require https://www.drupal.org/project/entity_uuid

This also needs some tests to check if UUIDs get saved properly.

FreekVR’s picture

FreekVR CreditAttribution: FreekVR commented
FileSize
add_uuid_to-2397863-4.patch5.94 KB

Here's an improved patch, with fixes for the previous one:
- Adds two tests to see if a quiz and quiz_question_relationship entity have a UUID set
- Adds a dependency to uuid
- Adds the new UUID fields in hook_schema()

Not sure why entity_uuid exists, because uuid in itself works fine:
https://www.drupal.org/node/2236497
https://www.drupal.org/node/2387671

Status: Needs review » Needs work

The last submitted patch, 4: add_uuid_to-2397863-4.patch, failed testing.

FreekVR’s picture

FreekVR CreditAttribution: FreekVR commented

Unfortunately the tests are failing due to the newly added dependency to uuid, which is not being automatically enabled:
Re. https://www.drupal.org/node/1844686

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

No worries I will test it manually.

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Needs work » Needs review
FileSize
interdiff-8-4.txt1.23 KB
add_uuid_to-2397863-8.patch5.21 KB

Reroll after #2414617: quiz admins should be able to view all feedback was committed.

Status: Needs review » Needs work

The last submitted patch, 8: add_uuid_to-2397863-8.patch, failed testing.

davidraijmakers’s picture

davidraijmakers CreditAttribution: davidraijmakers commented
FileSize
add_uuid_to-2397863-9.patch5.26 KB

For the latest dev version:

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: add_uuid_to-2397863-9.patch, failed testing.

anastasiaphil’s picture

anastasiaphil CreditAttribution: anastasiaphil at iO commented
FileSize
add_uuid_to-2397863-13.patch5.33 KB

Patch for version 7.x-5.5