Updates for Drupal 9 readiness [#3138446]

[x] Update code with current coding standards.
[x] Remove all deprecated functions.
[ ] Complete beta release for community testing.
[x] Update info.yml file with Drupal 9 core_version_requirement: ^8 || ^9
[x] Add dependency to jQuery UI Accordion and jQuery UI Tabs modules.

A D9 version will eventually result in moving the jQuery UI renderers to new module. This may just be included as a separate sub-module of this project or as a separate project.

Most jQuery UI asset libraries are deprecated and moved to contrib modules

Comment	File	Size	Author
#19	interdiff_3138446_16-19.txt	940 bytes	ankithashetty
#19	3138446-19.patch	1.56 KB	ankithashetty
#19	8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
#16	interdiff-11-16.txt	1.15 KB	ravimane23
#16	Quicktabs_d9_readiness-3138446-16.patch	1.58 KB	ravimane23
#16	8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
#11	interdiff-6-11.txt	1.12 KB	guptahemant
#11	Updates_for_d9_readiness-3138446-11.patch	2.7 KB	guptahemant
#11	8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
#6	3138446-6.patch	1.58 KB	lawxen
#6	8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass

Issue fork quicktabs-3138446

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3138446-updates-for-drupal compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 May 2020 at 03:19

shelane created an issue. See original summary.

Comment #2

shelane

English

CreditAttribution: shelane commented 21 May 2020 at 03:56

Issue summary:

View changes

Comment #3

shelane

English

CreditAttribution: shelane commented 23 May 2020 at 18:51

Issue summary:

View changes

Comment #4

shelane

English

CreditAttribution: shelane commented 8 June 2020 at 23:14

Issue summary:

View changes

Comment #5

ravimane23 CreditAttribution: ravimane23 as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented 25 June 2020 at 06:18

Issue summary:	View changes
Related issues:		+#3154733: Drupal 9 Readiness

Comment #6

lawxen CreditAttribution: lawxen commented 15 July 2020 at 21:35

Status:

Active

» Needs review

File	Size
3138446-6.patch	1.58 KB
8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass

Change:
1. Add composer.json to

    "require": {
        "drupal/core": "^8.8 || ^9",
        "drupal/jquery_ui_accordion": "^1.1",
        "drupal/jquery_ui_tabs": "^1.1"
    },

2. Update info.yml
3. Update libraries.yml

Comment #7

wrd CreditAttribution: wrd commented 16 July 2020 at 18:47

Getting the following error when trying to display a basic page containing a Quick Tabs block:

Error: Call to undefined method Drupal\\Core\\Entity\\EntityTypeManager::loadEntityByUuid() in /Users/foo/Sites/devdesktop/9.0/httpdocs/modules/contrib/quicktabs/src/Plugin/TabType/BlockContent.php on line 68

Comment #8

guptahemant CreditAttribution: guptahemant as a volunteer and at QED42 for Drupal India Association commented 15 August 2020 at 06:08

Assigned:

shelane

» guptahemant

Comment #9

guptahemant CreditAttribution: guptahemant as a volunteer and at QED42 for Drupal India Association commented 15 August 2020 at 06:18

Issue tags:

+DIACWAug2020

Comment #10

guptahemant CreditAttribution: guptahemant as a volunteer and at QED42 for Drupal India Association commented 15 August 2020 at 06:51

Status:

Needs review

» Needs work

I am able to reproduce the issue mentioned by @wrd in #7, hence marking the issue to needs work.

Comment #11

guptahemant CreditAttribution: guptahemant as a volunteer and at QED42 for Drupal India Association commented 15 August 2020 at 07:11

Assigned:	guptahemant	» Unassigned
Status:	Needs work	» Needs review

File	Size
Updates_for_d9_readiness-3138446-11.patch	2.7 KB
8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
interdiff-6-11.txt	1.12 KB

Here is an updated patch addressing issues from #7

Please review

Comment #12

siddhant.bhosale CreditAttribution: siddhant.bhosale as a volunteer and at QED42 commented 17 August 2020 at 10:58

Assigned:

Unassigned

» siddhant.bhosale

Comment #13

wrd CreditAttribution: wrd commented 17 August 2020 at 16:36

#11 is working for me; my tab blocks now display as expected.

Comment #14

siddhant.bhosale CreditAttribution: siddhant.bhosale as a volunteer and at QED42 commented 18 August 2020 at 04:53

Assigned:	siddhant.bhosale	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

The patch applies cleanly. Looks good to be merged.

 git apply -v --index ../Updates_for_d9_readiness-3138446-11.patch
Checking patch composer.json...
Checking patch quicktabs.info.yml...
Checking patch quicktabs.libraries.yml...
Checking patch src/Plugin/TabType/BlockContent.php...
Applied patch composer.json cleanly.
Applied patch quicktabs.info.yml cleanly.
Applied patch quicktabs.libraries.yml cleanly.
Applied patch src/Plugin/TabType/BlockContent.php cleanly.

Comment #15

wrd CreditAttribution: wrd commented 16 September 2020 at 17:56

Status:

Reviewed & tested by the community

» Needs work

Looks like something's changed in 8.x-3.x-dev, because the patch no longer applies.

Comment #16

ravimane23 CreditAttribution: ravimane23 as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented 17 September 2020 at 12:39

File	Size
Quicktabs_d9_readiness-3138446-16.patch	1.58 KB
8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
interdiff-11-16.txt	1.15 KB

Hello @wrd,

In 8.x-3.x-dev the re are changes in BlockContent.php which gets conflicts while applying patch #11.

I have update the patch which is working for me.

Comment #17

ravimane23 CreditAttribution: ravimane23 as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented 17 September 2020 at 12:41

Status:

Needs work

» Needs review

Comment #18

ankithashetty

Karnataka, India

CreditAttribution: ankithashetty as a volunteer and at Specbee for Drupal India Association commented 17 September 2020 at 13:03

Status:

Needs review

» Needs work

Hi @ravimane23, I think the line "license": "GPL-2.0+", in composer.json needs to be updated to "license": "GPL-2.0-or-later",.

After applying the updated patch try running composer validate,

$ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead

Changing status back to "Needs work"... Thanks!

Comment #19

ankithashetty

Karnataka, India

CreditAttribution: ankithashetty as a volunteer and at Specbee for Drupal India Association commented 17 September 2020 at 13:16

Status:

Needs work

» Needs review

File	Size
3138446-19.patch	1.56 KB
8.x-3.x: PHP 7.3 & MySQL 5.6, D8.9 2 pass
interdiff_3138446_16-19.txt	940 bytes

Updated the patch, kindly review...

Thank you!

Comment #20

wrd CreditAttribution: wrd commented 17 September 2020 at 15:05

#19 is working for me! Thanks!

Comment #21

meet_bhanvadia CreditAttribution: meet_bhanvadia at TATA Consultancy Services for Pfizer, Inc. commented 7 October 2020 at 08:43

Status:

Needs review

» Reviewed & tested by the community

#19 is working for me! Tested on version 8.9.6 and 9.0.3. No deprecation error and module is compatible with D9. It would be great if patch is committed to dev branch. Thanks!!

Comment #22

7 October 2020 at 15:49

shelane committed bcec5c1 on 8.x-3.x authored by lawxen

Issue #3138446 by guptahemant, ravimane23, ankithashetty, lawxen,...

Comment #23

shelane

English

CreditAttribution: shelane commented 7 October 2020 at 15:54

Issue summary:	View changes
Status:	Reviewed & tested by the community	» Active

There were several requests for the D9 capability, so I've committed the changes necessary for that. There are still outstanding issues that are blocking me from a beta tag. If you're comfortable with the dev version for D9, have at it. If there are enough requests for an actual release for D9, it will be tagged with another alpha.