quicktab is broken when empty tabs are hidden [#2396031]

We are using quicktab 7.3 version. In one quicktab instance, we have 13 tabs, and we need to hide empty blocks. The render of 'quicktabs' doesn't work for this instance, while the other two render 'accordion' and 'ui_tabs' are working fine.

I figured this issue happens because the way of getting tab index is depending on the order of tab link inside the tab link group.

See js/quicktabs.js

  $ul.find('li a').each(function(i, element){
    element.myTabIndex = i;
}

When we hide the empty tabs, this element.myTabIndex will be wrong. For example, tab0 tab1,tab3 has content, but tab2 doesn't have content. Then for tab3, the table index should be 3, but the current code will get 2 for tab3, because tab2 link has been removed in html structure.

Attached patch works for me.

Comment	File	Size	Author
#20	quicktabs-2396031-fix_empty_tabs.patch	1.76 KB	daniel_j
#20	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 2 pass PHP 5.6 & MySQL 5.5, D7 2 pass
#9	fix_empty_tabs.patch	1.77 KB	oscaral
#9	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply
#5	fix_empty_tabs.patch	1.92 KB	larkydoo
#5
	fix_empty_tabs.patch	1.87 KB	smiletrl

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

smiletrl CreditAttribution: smiletrl commented 19 December 2014 at 10:47

Status:

Active

» Needs review

Comment #2

jazzitup CreditAttribution: jazzitup commented 14 March 2015 at 16:32

Status:

Needs review

» Reviewed & tested by the community

I came across the same issue, tested it and I can confirm the patch fixes the flaw.

Comment #3

gunosov CreditAttribution: gunosov commented 22 March 2015 at 07:48

Works for me. Thanks!

Comment #4

pramodganore CreditAttribution: pramodganore commented 6 May 2015 at 19:43

Can confirm this works.

FYI: I was using the Phpstorm git patch apply and it does not delete some code and sticks the following code in wrong location.
this.tabObj = Drupal.settings.quicktabs[qtKey].tabs[this.tabIndex];
this.tabpage_id = 'quicktabs-tabpage-' + el.qt_name + '-' + this.tabKey;

I am glad i do a cross check on my patches, this saved me more dev time.

Comment #5

larkydoo CreditAttribution: larkydoo as a volunteer commented 21 July 2015 at 21:38

File	Size
fix_empty_tabs.patch	1.92 KB

I wasn't able to get the patch to apply using the patch command. It was unable to find the third Hunk:

- var i = 0;
- for (var key in Drupal.settings.quicktabs[qtKey].tabs) {
- if (i == this.tabIndex) {
- this.tabObj = Drupal.settings.quicktabs[qtKey].tabs[key];
- this.tabKey = key;
- }
- i++;
- }

When I looked at the code, it was actually the following:

var i = 0;
for (var i = 0; i < Drupal.settings.quicktabs[qtKey].tabs.length; i++) {
if (i == this.tabIndex) {
this.tabObj = Drupal.settings.quicktabs[qtKey].tabs[i];
this.tabKey = i;
}
}

I'm attaching a patch that should address this issue. It has not been tested, so use at your own risk.

I manually edited the quicktabs.js file using the code in the patch, and it works mahvellously.

Thanks!

Laurie

Comment #6

21 July 2015 at 21:39

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 5: fix_empty_tabs.patch, failed testing.

Comment #7

larkydoo CreditAttribution: larkydoo as a volunteer commented 28 July 2015 at 21:43

RE: Patch failure: My patch is designed to work with quicktabs-7.x-3.6; the original patch should work with quicktabs-7.x-3.x-dev.

Comment #8

jazzitup CreditAttribution: jazzitup commented 28 July 2015 at 22:31

@larkydoo: "Make patches against the -dev version because it is the latest code."

Please always strictly follow the manual: https://www.drupal.org/node/707484

Comment #9

oscaral

Madrid

CreditAttribution: oscaral commented 16 October 2015 at 10:26

Version:

7.x-3.x-dev

» 7.x-3.6

File	Size
fix_empty_tabs.patch	1.77 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply

@larkydoo solution works for us for 7.x-3.6 (thanks :) )

Comment #10

martinwrightinfo CreditAttribution: martinwrightinfo commented 1 March 2016 at 17:44

I've tested the patch above (#9) and can confirm that this fixes the problem in 7.x-3.6.

Comment #11

fdefeyter@gmail.com CreditAttribution: fdefeyter@gmail.com commented 2 May 2016 at 14:21

I confirm this patch works as well. Why isn't it commited? thx

Comment #12

jazzitup CreditAttribution: jazzitup commented 3 May 2016 at 02:33

Status:

Needs work

» Reviewed & tested by the community

Comment #13

3 May 2016 at 02:35

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 9: fix_empty_tabs.patch, failed testing.

Comment #14

alex_gred CreditAttribution: alex_gred commented 3 August 2016 at 12:44

@smiletrl solution working fine.
Thanks!

Comment #15

gajanannehul CreditAttribution: gajanannehul as a volunteer and at Clarion Technologies commented 16 August 2016 at 06:47

#9 is working fine.
Thanks!!!

Comment #16

markdc

his lordship

English

CreditAttribution: markdc commented 29 September 2016 at 15:02

I can confirm #9 is working. Thank you.

Comment #17

SocialNicheGuru CreditAttribution: SocialNicheGuru commented 2 October 2016 at 17:28

The patch did not apply correctly

patch -p1 < patchfile
patching file js/quicktabs.js
Hunk #1 succeeded at 25 with fuzz 2 (offset 3 lines).
Hunk #2 succeeded at 44 (offset 5 lines).
Hunk #3 FAILED at 69.
1 out of 3 hunks FAILED -- saving rejects to file js/quicktabs.js.rej
> test/sites/test/modules/quicktabs$ more js/*rej
--- js/quicktabs.js
+++ js/quicktabs.js
@@ -69,13 +82,9 @@
this.element = el;
this.tabIndex = el.myTabIndex;
var qtKey = 'qt_' + el.qt_name;
- var i = 0;
- for (var i = 0; i < Drupal.settings.quicktabs[qtKey].tabs.length; i++) {
- if (i == this.tabIndex) {
- this.tabObj = Drupal.settings.quicktabs[qtKey].tabs[i];
- this.tabKey = i;
- }
- }
+ this.tabKey = this.tabIndex;
+ this.tabObj = Drupal.settings.quicktabs[qtKey].tabs[this.tabIndex];
+
this.tabpage_id = 'quicktabs-tabpage-' + el.qt_name + '-' + this.tabKey;
this.container = $('#quicktabs-container-' + el.qt_name);
this.tabpage = this.container.find('#' + this.tabpage_id);