Problem/Motivation

Users see the list of all queues even if they don't have permission to process the queue.

Proposed resolution

Test for QueueProcessController::access() on OverviewForm when listing queues.

Issue fork queue_ui-3410647

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

artis created an issue. See original summary.

artis opened merge request !38

artis changed the visibility of the branch 3410647-only-show-queues to hidden.

artis’s picture

artis commented
Status: Active » Needs review

All of the test failures were related to other parts of the module not this code. I'm using this code in production on a site.

ptmkenny made their first commit to this issue’s fork.

ptmkenny’s picture

ptmkenny commented

I rebased since the tests in 3.1.x are passing; let's see if this passes now.

ptmkenny’s picture

ptmkenny commented
Version: 3.1.x-dev » 3.2.x-dev
Status: Needs review » Needs work

The MR breaks the phpunit tests, so I'm setting this to "Needs work."

The tests for 3.1.x are passing, so this MR is actually at fault.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

I left a review comment

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Yes, the current change also breaks the test, as the testing user is usually granted only `admin queue_ui` permission. So, tests need to be updated as well.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Issue tags: +Needs tests, +Needs reroll
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Version: 3.2.x-dev » 4.0.x-dev

immaculatexavier changed the visibility of the branch 3410647-process-permission-to-view to hidden.

immaculatexavier changed the visibility of the branch 3410647-process-permission-to-view to hidden.

immaculatexavier changed the visibility of the branch 3410647-process-permission-to-view to active.