Port to Drupal 8 [#2237495]

Now that #2142903: Port to Drupal 8 has been fixed the port to Drupal 8 is unblocked. Assigning to version 7.x-1.0 for now since there's no 8.x branch yet.

Comment	File	Size	Author
#9	qa_checklist-drupal_8-2237495-9.patch	42.96 KB	shkiper
#8	qa_checklist-drupal_8-2237495-8.patch	42.97 KB	shkiper
#6	qa_checklist-Drupal_8-2237495-6.patch	39 KB	shkiper
#2	qa_checklist-Drupal_8-2237495-2.patch	10.03 KB	shkiper

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Eidolon Night

Batavia, NY

CreditAttribution: Eidolon Night commented 30 July 2014 at 03:36

Version:	7.x-1.0	» 7.x-2.x-dev
Assigned:	Unassigned	» Eidolon Night

Once the 7.x-2.x branch has a stable release, I'll start on a D8 port based on the dev release of Checklist API.

Comment #2

shkiper CreditAttribution: shkiper commented 17 January 2015 at 15:44

File	Size
qa_checklist-Drupal_8-2237495-2.patch	10.03 KB

Hi, I made a version of this module that works with Drupal 8 beta
Here is my patch

Comment #4

anavarre

French

🇪🇺

CreditAttribution: anavarre commented 19 January 2015 at 10:34

Status:

Active

» Needs review

Comment #5

anavarre

French

🇪🇺

CreditAttribution: anavarre commented 19 January 2015 at 17:19

Status:

Needs review

» Needs work

Also, patch doesn't apply here:

$ git apply -v qa_checklist-Drupal_8-2237495-2.patch
qa_checklist-Drupal_8-2237495-2.patch:52: trailing whitespace.
qa_checklist.checklist:
qa_checklist-Drupal_8-2237495-2.patch:53: trailing whitespace.
  title: QA Checklist
qa_checklist-Drupal_8-2237495-2.patch:54: trailing whitespace.
  description: QA Checklist.
qa_checklist-Drupal_8-2237495-2.patch:55: trailing whitespace.
  route_name: checklistapi.checklists.qa_checklist
qa_checklist-Drupal_8-2237495-2.patch:56: trailing whitespace.
  parent: system.admin_config_development
Checking patch qa_checklist.info...
error: while searching for:
name = QA Checklist
description = Provides a quality assurance checklist.
core = 7.x
package = Other
dependencies[] = checklistapi
configure = admin/config/development/qa-checklist

error: patch failed: qa_checklist.info:1
error: qa_checklist.info: patch does not apply
Checking patch qa_checklist.info.yml...
Checking patch qa_checklist.install...
Checking patch qa_checklist.links.menu.yml...
Checking patch qa_checklist.module...
error: while searching for:
 * A quality assurance checklist.
 */

/**
 * Implements hook_checklistapi_checklist_info().
 */

error: patch failed: qa_checklist.module:5
error: qa_checklist.module: patch does not apply

I also tried with git apply -v qa_checklist-Drupal_8-2237495-2.patch without success.

Comment #6

shkiper CreditAttribution: shkiper commented 19 January 2015 at 19:19

Status:

Needs work

» Needs review

File	Size
qa_checklist-Drupal_8-2237495-6.patch	39 KB

Here is my new patch. I made it from the master branch.

Comment #7

anavarre

French

🇪🇺

CreditAttribution: anavarre commented 27 January 2015 at 14:30

Status:

Needs review

» Needs work

I *think* you should work out of 7.x-2.x as long as there's no D8 branch available on the project repo. That being said, I couldn't test the module since it's throwing a PHP fatal at /admin/config/development/qa-checklist

[Tue Jan 27 15:28:38.036918 2015] [:error] [pid 2277] [client 127.0.0.1:60154] PHP Fatal error: Method Drupal\\Core\\Url::__toString() must not throw an exception in /var/www/html/d8/core/lib/Drupal/Core/Url.php on line 0, referer: http://d8.local/admin/reports/checklistapi