Parameter $config has null default value, but is not marked as nullable.

  public static function create(ContainerInterface $container, array $config = NULL) {
CommentFileSizeAuthor
#5 purge-3511668.patch1.42 KBklausi

Issue fork purge-3511668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jakegibs617 created an issue. See original summary.

jakegibs617 opened merge request !53

jakegibs617 changed the visibility of the branch 3511668-php-8.4-support to hidden.

klausi made their first commit to this issue’s fork.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
Issue tags: +PHP 8.4
StatusFileSize
new purge-3511668.patch1.42 KB

I pushed the empty array as default value instead, please review!

Also attaching stable patch file here for composer patches.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP 8.4 support
andriy khomych’s picture

andriy khomych commented
Status: Needs review » Reviewed & tested by the community

Thanks, Klausi, looks good to me.
Moved to RTBC.

johnatas’s picture

johnatas commented

Hello,

Tested OK on Drupal 11.2.2 and 11.2.3 with purge 3.6.0.

Would it be possible to merge the MR so that this fix is included in the next release?

Thank you.

esod’s picture

esod commented

Patch applies using composer. Drupal 10.5.2. PHP v8.4. Thank you.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 8.x-3.6 » 8.x-3.x-dev

japerry made their first commit to this issue’s fork.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Had to make a few updates to ensure tests were passing. Committed!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.