On Drupal 9.5, installing the module freezes the publish checkbox on all nodes - even for administrators - and despite having double checked the permissions. Then when the only option left is to uninstall the module and I do so, all the views that were using the module are deleted.

Issue fork publishcontent-3389401

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

David Fiaty created an issue. See original summary.

paulrad’s picture

paulrad commented
Assigned: Unassigned » paulrad

paulrad opened merge request !4

paulrad’s picture

paulrad commented
Assigned: paulrad » Unassigned
Status: Active » Needs review

I've tested and the module works as expected.
@David Fiaty, please go to the admin/config/workflow/publishcontent and enable 'Publish and unpublish via checkbox' if you want to have this possibility.

But it could be great to have this option enabled by default, so I'm making a merge request for maintainers to decide.

David Fiaty’s picture

David Fiaty commented

The suggestion works indeed. However I believe a freshly installed module shouldn't change any core Drupal config parameter without user action.

I've reinstalled the module and it's all good. But I'm terrified about uninstalling or disabling it again because I don't want to lose the numerous views that use the module. Is this an expected behaviour?

IMO this module should join the Drupal core!
Great work and thank you very much for the quick reply.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Postponed (maintainer needs more info)

This still happens on Drupal 10/11 with the latest version of the module?

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.6 » 8.x-1.x-dev
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

I don't really see an immediate cause of why uninstalling this module would delete views.

I do follow the idea of setting the checkbox enabled by default though, so things work like they did before, until you choose to disable the option.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented

Ok.
Then the proper place to set defaults would be
https://git.drupalcode.org/project/publishcontent/-/blob/8.x-1.x/config/...

The update hook can get the update too but it is not very relevant.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

nexusnovaz made their first commit to this issue’s fork.

nexusnovaz’s picture

nexusnovaz commented

Hey, updated publishcontent.settings.yml to make ui_checkboxes true. Should the change to the .install be reverted back to 0?

Will mark as needs review in case this is all good. Thanks

nexusnovaz’s picture

nexusnovaz commented
Status: Needs work » Needs review
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Updating an existing update hook won't have any effect on active installs. Not sure we really need to create a new update hook for this

kurttrowbridge’s picture

kurttrowbridge
he/him
commented

I didn't test the merge request on a fresh install, so not going to mark this RTBC myself, but just thought I'd note that I got tripped up by this issue after having enabled the module on a Drupal 10 site, and the config change suggested in the MR and comment #4 got us back to the workflow we were expecting, so what's in the MR makes sense to me. Thanks!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

For #13 and #11