Add hooks to modify access control to allow other modules to make use of this functionality such as Organic Groups

Please find a patch which adds the hooks and implements them on behalf og organic groups. api.php file included.

Rerolled #1 for latest dev updates.

Rerolled for new release

Tests passed - committing to 7.x-1.x

I'd prefer to keep any og integration separate from the rest of the module so that it only modifies via the hooks. The tests are failing because the new code is interfering with the normal operation of the module. OG specific code should only reside within the functions publishcontent_og_permission, og_publishcontent_publish_access, og_publishcontent_unpublish_access

Is the publishcontent_og_permonly checkbox necessary? Permission model is such that you can only edit if you are granted permission either globally or within the group. I personally feel that if you want to deny the global permission within a group then that's specialist functionality within your own site and should not belong in this module. You can easily implement it for your site by using the developer integration hooks that were recently added.

Hi @Nikit, thanks for your message and trying to improve the module, it is appreciated.

well, then you should out your og_publishcontent_publish_access and og_publishcontent_unpublish_access functions from your module, and create new one submodule, for example named as publishcontent_og.module.

I disagree - plenty of modules implement hooks on behalf of other modules - there is no need for a sub module to implement three hooks.

Your publishcontent_publish_access function is too strict: it's deny access if one of modules deny it and break cycle: so I cann't control publish access via custom module, since it was terminated before accessing it - it's why I should patching, instead writing own permission on custom module.

I see what you are saying about being too strict.

The permission control model here is very simplistic and should copy the model used by node_access. hook_publishcontent_publish_access implementations should either FALSE to flat deny access, TRUE to allow access or NULL say they don't care, in which case nothing will be allowed unless at least one other hook_publishcontent_publish_access said allow access. This is currently not happening.

So instead of foreach (module_invoke_all('publishcontent_publish_access', $node, $account), for example alteration will better (or just rewrite your code to be last module stronger):

Adding a alter hook here doesn't make the module stronger, it just changes the permission model to a last module wins model. I would rather do the node_access type model as described above properly.

Also I made there some fixes, like removing non-groups content types in permissions list. And next comparing $account->uid == $account->uid on your code have been fixed to $account->uid == $node->uid.

So you did - I have committed to latest development branch. Thanks!

@Nikit / testbot - what do you think of this patch...

I've checked this over and I am happy the patch in #12 represents the original intention of the module and addresses @Nikit's issue. Committing to 7.x-1.x branch.