Verifying a platform does not sync up codebase on remote server

Also can not create a new platform

Ok found out *why* this isn't working. From a platform-verify:

rsync -e 'ssh ' -akzv --exclude=".git" --exclude=".gitignore" --exclude=".hg" --exclude=".hgignore" --exclude=".hgrags" --exclude=".bzr" --exclude=".bzrignore" --exclude=".bzrtags" --exclude=".svn" --include="sites/all" --exclude="sites/*" --stats --progress --relative --keep-dirlinks --omit-dir-times --delete '/var/aegir/config/server_remote' 'aegir@remote.example.com:/'

Should be:

rsync -e 'ssh ' -akzv --exclude=".git" --exclude=".gitignore" --exclude=".hg" --exclude=".hgignore" --exclude=".hgrags" --exclude=".bzr" --exclude=".bzrignore" --exclude=".bzrtags" --exclude=".svn" --include="sites/all" --exclude="sites/*" --stats --progress --relative --keep-dirlinks --omit-dir-times --delete '/var/aegir/platforms/platform_name' 'aegir@remote.example.com:/'

For some reason it is trying to rsync the platform to the config path, not the platform path. I will try find out where this happens in the code if I get a chance but if someone else knows, please provide a patch/point me to the correct place.

Tested on 7.x-3.192

So the problem is in Provision/Context/server.php on line 173 there is the following:

if (is_null($path)) {
  $path = $this->config_path;
}

When it is syncing the codebase, $path is NULL and so it is being set to $this->config_path. It doesn't seem to be aware of composer_git_path which is probably what it should be syncing.

Problem also happens with a manually created codebase, so not composer specific.

So this patch solves the issue for git + composer platforms when hosting_git is enabled, however traditional platforms (and possibly other types - couldn't test those) still don't sync with this module enabled.