Very strange new behavior.

Drupal 8.8 platform, composer based.

Saw a warning about no "version" array key.

Added debug logging, contrib modules that have no version key in the info.yml file triggered a warning, then further down, we got SQL fail when RID was null.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'rid' cannot be null in /var/aegir/devmaster-1.x/includes/database/database.inc:2227
Stack trace:
#0 /var/aegir/devmaster-1.x/includes/database/database.inc(2227): PDOStatement->execute(Array)
#1 /var/aegir/devmaster-1.x/includes/database/database.inc(697): DatabaseStatementBase->execute(Array, Array)
#2 /var/aegir/devmaster-1.x/includes/database/mysql/query.inc(36): DatabaseConnection->query('INSERT INTO {ho...', Array, Array)
#3 /var/aegir/devmaster-1.x/profiles/devmaster/modules/contrib/hosting/package/hosting_package.instance.incms/v0.0.64c(149): InsertQuery_mysql->execute()
#4 /var/aegir/devmaster-1.x/profiles/devmaster/modules/contrib/hosting/package/hosting_package.instance.inc(257): hosting_package_instance_create(Object(stdClass))
#5 /var/aegir/devmaster-1.x/profiles/devmaster/modules/contrib/hosting/package/hosting_package.instance.inc(83): hosting_package_instance_save(Object(stdClass))
#6 /var/aegir/devmaster-1.x/profiles/devmaster/modules/contrib/hosting/platform/hosting_platform.drush.inc(83): hosting_package_instance_sync(NULL, NULL, Array, NULL, Array)
#7 /var/aegir/devmaster-1.x/includes/module.inc(965): hosting_platform_post_hosting_verify_task(Object(stdClass), Array)
#8 /var/aegir/devmaster-1.x/profiles/devmaster/modules/contrib/hosting/task.hosting.inc(201): module_invoke_all('post_hosting_ve...', Object(stdClass), Array)

The code in hosting_package.instance should check to see if "version" key is set to avoid this edge case. We are not sure why this didn't cause problems before.

Branch and patch coming. Have to push changes hosting_package.instance to test.

Comments

Jon Pugh created an issue. See original summary.

  • Jon Pugh committed 2b7eb5a on 3118152-package-version-missing
    Issue #3118152: Handle missing version metadata in info.yml files.
    
colan’s picture

Status: Active » Needs review

Code makes sense to me, but I haven't tested it. I've definitely seen those warnings. Thanks for looking into it.

Jon Pugh’s picture

Assigned: Unassigned » Jon Pugh
Issue tags: +devshop patches

Can anyone else review?

We should really work on setting up drupal.org testing. We have no insight here if the patches fail or not!

  • Jon Pugh committed 2b7eb5a on 7.x-4.x
    Issue #3118152: Handle missing version metadata in info.yml files.