When downloading modules to extend Aegir hostmaster, typically users would use "drush dl" command.

By default, this sets the destination to "sites/all/modules".

However, when upgrading, the platform is rebuilt, so hostmaster modules in sites/all/modules are lost. Most users don't know this, it never warns them.

I tried, and if you add "destination" => "sites/hostmaster.com/modules" to the hostmaster alias, drush dl commands automatically go there.

Let's add this to the hostmaster alias so it's a little easier to extend.

Comments

Jon Pugh created an issue. See original summary.

colan’s picture

This is a much better idea than my usual:

drush @hm dl --destination=$(drush dd @hm:%site)/modules/contrib

helmo’s picture

Title: Add "destinaion" to Hostmaster alias so "drush dl module" commands put the module in the right folder. » Add "destination" to Hostmaster alias so "drush dl module" commands put the module in the right folder.

Sounds like a great idea

  • Jon Pugh committed 4b6c324 on 2995091-hostmaster-dl-destination
    Issue #2995091: Add "destination" to Hostmaster alias so "drush dl...
Jon Pugh’s picture

That should do it?

Jon Pugh’s picture

Uhhh...

Just discovered --use-site-dir option. Maybe that's better?

Jon Pugh’s picture

Status: Active » Needs work

Yeah, --use-site-dir works great.

  • Jon Pugh committed 855207d on 2995091-hostmaster-dl-destination
    Issue #2995091 by Jon Pugh: Add "destination" to Hostmaster alias so "...
Jon Pugh’s picture

Status: Needs work » Needs review

  • helmo committed 1d8ce20 on 2995091-hostmaster-dl-destination
    Issue #2995091: Add "destination" to Hostmaster alias so "drush dl...
helmo’s picture

Status: Needs review » Reviewed & tested by the community

Your code only worked on new installations ... I've now committed the same change in migrate.hostmaster.inc

Test pipeline running in https://gitlab.com/aegir/provision/pipelines/38810538

helmo’s picture

Status: Reviewed & tested by the community » Fixed

merged

  • helmo committed 67e8c70 on 7.x-3.x authored by Jon Pugh
    Issue #2995091: Add "destination" to Hostmaster alias so "drush dl...
  • helmo committed caa1b95 on 7.x-3.x authored by Jon Pugh
    Issue #2995091 by Jon Pugh: Add "destination" to Hostmaster alias so "...
  • helmo committed db7adae on 7.x-3.x
    Issue #2995091: Add "destination" to Hostmaster alias so "drush dl...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.