Unable to migrate sites involving webform in Drupal 8

For reference the code is in platform/provision_drupal.drush.inc

The only thing we get from that is a schema version number.

Maybe we should make it work with an 'unknown' schema version.... I don't like the idea of parsing include statements.

Worth speaking to the Webform developer? I know JRockowitz well...

Wondering what other solutions there might be that we aren't thinking of.

Is this how Drupal core checks itself for updates? Maybe we should include the file to read all functions and the include?

I really want to keep all the update code in an include.

Core bootstraps each module's install file and does a loop that uses function_exists('MODULE_NAME_update_N');

Steven, I'm glad your patch doesn't just follow just any include statement. Eval'ing the .install file would be even nastier ;)

I can imagine more contrib's having the desire to move these hooks ... Could this name be suggested as a 'standard'?

I looked in the core queue and found https://www.drupal.org/project/drupal/issues/633332#comment-5106756 which seems to suggest that webform should move those hooks to e.g. webform.install.api.php

Either this or we need to make our version comparison work with 'unknown' as I suggested in #2.

If anyone else is moving their update hooks into an include file, they are going to use an 'includes' directory. The solution in #3 makes sense but maybe it should just pull in all the include files.

Can't we figure out how Drupal loads this information and just use that?

We can't predict where people might put their code, it would be wrong of us to assume everyone would follow the same patterns.

Let's dig in a little here to figure out what function Drupal itself calls the find this information?

The Webform module is probably the only D8 module 100+ update hooks and it is possibly the only module using an include in the install file.

Here was our fix, also a little ugly. Uses a regex to locate any include statements in the install file.

Regex would need some work. The Advanced Aggregation module has the following line which is picked up.

module_load_include("missing.inc", "advagg");

This issue is still a pain, any further suggestions on how we can fix this beyond #13?

I added this to the META release node so it will get more attention.

I'm still not sure why we need a special function for this. Doesn't drupal core have a way to load these version functions?

See #3007818: [meta] Aegir 3.17 release (bugfix/patches)

We've been actively delaying upgrading aegir because I have to take additional steps to re-patch every server.

I don't see a problem with patch #3.

The patch doesn't appear to do any harm, and it solves the most common problem (webform) immediately. No need to wait for webform to change anything, and certainly no need to predict the future of update hook includes for contrib modules. Solve the problem first, and if someone cares to find the 'right' way later, they can submit another patch.

Without the patch, most of the dozens of sites we manage cannot be migrated, and that's a show-stopper.

I vote to get #3 in the next release.

We have included both suggested patches in the Provision version used in BOA already.

I was at a blocker migrating sites this morning (even if the webform versions on both platforms were identical), there would still be an error in Aegir when examining platforms because it couldn't display the correct update hook. The patch (#3) got me through for now and I can keep upgrading sites. Thanks for the patch Steven Jones, it was exactly what I was hoping to find. It just adds a few lines as an additional check, so I don't see how this is a bad thing ultimately. I now can migrate all I want, so thank you! :)

Patch 13 stopped working with Webforms 8.x-5.2. The attached has an improved regex.

Patch is good.

Tested patch #21 against latest provision release successfully.

Uses realpath instead of sprintf to combine path segments.

Creating a lot of warnings on platform verify:

file_get_contents(/modules/system//includes/unicode.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/modules/locale//includes/language.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/modules/locale//includes/locale.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/modules/locale//modules/locale/locale.module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/modules/locale//includes/language.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/media//includes/file.mimetypes.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/flag/flag_bookmark/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/panels_mini/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/views_slideshow/contrib/views_slideshow_cycle/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/countries//includes/iso.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
1 s.
warning
file_get_contents(/sites/all/modules/media//includes/file.mimetypes.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/flag/flag_bookmark/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/panels_mini/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/panels/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/views_slideshow/contrib/views_slideshow_cycle/module): failed to open stream: No such file or directory provision_drupal.drush.inc:598
-
warning
file_get_contents(/sites/all/modules/countries//includes/iso.inc): failed to open stream: No such file or directory provision_drupal.drush.inc:598

Try patch 24.

Gah, sorry. Latest patch works.

Patch 24 looks good.

Thanks!