Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
My site has lots of directories. The function logs too much garbage: for me, successful deletion is not important enough event to log it every time. IMO we should only log unsuccessful deletions, and provide single line summary for success ones.
The bug makes provision log so big that browser hangs for while when I open it in Aegir interface.
Comment | File | Size | Author |
---|---|---|---|
#6 | prevent-recursive-delete-notices.patch | 1.41 KB | chertzog |
Comments
Comment #1
crea CreditAttribution: crea commentedComment #2
crea CreditAttribution: crea commentedQuick & dirty solution:
This way, success is only logged for top level directory.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedI think it's better to fully log the deletion of all directories, and no-one else has complained about this so marking as won't fix.
Comment #4
crea CreditAttribution: crea commentedOh this is one of the reasons I forked Aegir for my own use and no longer report issues here.
Reasonable, sane requests are ignored at best.
The patch wouldn't harm anyone. It only removes notice-level debug messages noone cares about anyway, and it fixes problems for big sites with lots of directories. The fact that it wasn't requested before doesn't mean the problem doesn't exist.
Btw, in all good software notice-level debug messages are not logged by default.
Comment #5
Steven Jones CreditAttribution: Steven Jones commentedOkay okay, fair enough. I'm just trying to thin down the issue queue to something more manageable. Would you be able to provide a patch for this?
I can see why this might be useful both ways, so would commit something that would set the logging level to something less verbose by default.
Comment #6
chertzogHere is a patch with the code from #2
Comment #7
anarcat CreditAttribution: anarcat commentedhmmm... that's not right. i believe that !empty() is actually important error checking.
anyways, if we want to introduce changes in the verbose mode, we shouldn't touch anything else - those changes here seem to be unrelated...
Comment #7.0
anarcat CreditAttribution: anarcat commentedcorrection
Comment #8
ergonlogicNew features need to be implemented in Aegir 3.x, then we can consider back-porting to Aegir 2.x.