Problem/Motivation

We want theme settings files to load over any other potential styles.

Proposed resolution

Move these lines to load within the theme region for styles:

  • color
  • font
  • size
CommentFileSizeAuthor
#2 prototype-theme-3380579.patch831 bytesshreya_th

Issue fork prototype-3380579

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

shreya_th’s picture

shreya_th commented
StatusFileSize
new prototype-theme-3380579.patch831 bytes

I've moved the settings into theme section within the libraries.yml file successfully. Kindly review the patch file .

pixelwhip’s picture

pixelwhip commented
Status: Active » Needs work

Thanks for taking a swing at this. This patch misses `dist/css/global/settings/space.css`.

shreya_th’s picture

shreya_th commented

@pixelwhip `dist/css/global/settings/space.css` is already present inside base section in patch .

jldust opened merge request !51

jldust’s picture

jldust commented
Assigned: jldust » pixelwhip
Status: Needs work » Needs review

I've created a MR based on the comments listed above, please review.

  • jldust committed 023ecfa0 on 5.x 
    Issue #3380579 by jldust, Shreya_th, pixelwhip: Move settings into theme...
jldust’s picture

jldust commented
Status: Needs review » Fixed

This has been merged in and will be included in the next release.

  • jldust committed 023ecfa0 on 5.0.x 
    Issue #3380579 by jldust, Shreya_th, pixelwhip: Move settings into theme...
jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)