Problem/Motivation

By default the mobile menu controls are empty, we would like to attach a mobile menu library that is fully accessible out of the box.

Proposed resolution

Bring in menu toggle support and functionality similar to:

Remaining tasks

  • Add initial functionality
  • Testing by community & accessibility feedback
  • Create & review documentation for new menu setup

Issue fork prototype-3345126

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

jldust’s picture

jldust commented
Title: Default Mobile Menu Support » Mobile Menu Support
jldust’s picture

jldust commented
Status: Active » Needs review

This is just a first pass at adding accessible menus into the 4.x Prototype branch. It is ready for community feedback & additional testing.

jldust’s picture

jldust commented
Issue summary: View changes

jldust opened merge request !23

michaelablackham’s picture

michaelablackham commented

This looks great!

The only change I am looking for is to clean it up a little bit:

  1. Add aria-label to the <nav>
  2. Remove the aria-labelledby on the <nav>
  3. Remove the visually hidden h2.

This way it is just a little cleaner:

<nav aria-label="main" id="block-mainnavigation">

jldust’s picture

jldust commented
Issue summary: View changes

  • jldust committed ac036994 on 4.x 
    Issue #3345126 by jldust, michaelablackham: Mobile Menu Support
jldust’s picture

jldust commented
Status: Needs review » Fixed

Thanks @michaelablackham for your feedback and testing! This has been merged into the 4.x branch and will be included in the next release.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)