CommentFileSizeAuthor
#6 protected_node-add_variable_support-2549747-6.patch16.94 KBgrimreaper
#2 protected_node-add_variable_support-2549747-2.patch16.15 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new protected_node-add_variable_support-2549747-2.patch16.15 KB

Here is a first commit.

I didn't managed to be able to translate the per content type description.

Status: Needs review » Needs work

The last submitted patch, 2: protected_node-add_variable_support-2549747-2.patch, failed testing.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review

needs review for manual review.

Grimreaper queued 2: protected_node-add_variable_support-2549747-2.patch for re-testing.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Related issues: +#1601950: Add support for content type settings forms.
StatusFileSize
new protected_node-add_variable_support-2549747-6.patch16.94 KB

Here is a second patch where I fixed the group for node type dependent variables.

I also added the password variables even if its are not translatable because of the form element key rewritten.

Still no translation form on the node edit form because of this related issue #1601950: Add support for content type settings forms..

Thanks for the review. (I will merge the patch in one or two weeks if there is no review.)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

This is merged now.

  • Grimreaper committed 4c8ded4 on 7.x-1.x 
    Issue #2549747 by Grimreaper: Support for variable API.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.